Terminal interface to find, download, and stream movies, TV shows, and live TV using local media players.
fix(player): strip redundant ytdl-raw-options header injection in mpv command
Samir Hossainsfa1086e6257b
diff --git a/CHANGELOG.md b/CHANGELOG.mdindex 561d0fa..697da0d 100644--- a/CHANGELOG.md+++ b/CHANGELOG.md@@ -1,5 +1,11 @@# Changelog+## [Unreleased]++### Fixed+- **MPV Player Header Flag Construction**:+ - Removed redundant `--ytdl-raw-options` header pass-through in `src/player.rs`, preventing option parsing aborts (exit code 1) caused by unescaped commas inside standard browser `User-Agent` strings.+## [0.1.22] - 2026-09-21### Added- **Dramachi Native Streaming Provider**:diff --git a/docs/players.md b/docs/players.mdindex 589787d..76e72d1 100644--- a/docs/players.md+++ b/docs/players.md@@ -30,7 +30,7 @@ by the image picker, then clamped to a fixed range.Playback sources (for example 4KHD and MovieBox) may carry `Referer`/`User-Agent` headers.MovieBox DASH streams additionally carry signed `Cookie` headers for CloudFront authentication.-mpv/IINA send them via `http-header-fields` (`--http-header-fields=...` or `--mpv-http-header-fields=...`),+- mpv and IINA send headers via native CLI flags (`--user-agent`, `--referrer`, and `--http-header-fields`), which are read by demuxers and automatically forwarded by internal Lua hooks to yt-dlp.while VLC maps them to `--http-referrer` / `--http-user-agent`. Android intent playback forwards `Referer`/`User-Agent` extras when using `am`/`termux-am`, and supports unauthenticated streams (CircleFTP, DhakaFlix, IPTV) and CDN streams natively.The `supports_headers` gate in `app/playback.rs` validates whether a player can satisfy required stream headers. For VLC and Android Intent, signed CloudFront `Cookie` streams (such as MovieBox DASH manifests) are automatically supported via the detached loopback sidecar proxy (`--proxy-for-vlc`). The proxy injects the signed CloudFront cookies and auth headers server-side and streams chunks directly over localhost.## Subtitlesdiff --git a/src/player.rs b/src/player.rsindex 094fad3..972177f 100644--- a/src/player.rs+++ b/src/player.rs@@ -445,13 +445,6 @@ fn mpv_command(command.arg(format!("{prefix}http-header-fields={name}: {value}"));}}-- let ytdl_headers = headers- .iter()- .map(|(name, value)| format!("add-header={name}:{value}"))- .collect::<Vec<_>>()- .join(",");- command.arg(format!("{prefix}ytdl-raw-options={ytdl_headers}"));}if let Some(subtitle) = subtitle {let opt = if iina {@@ -1618,6 +1611,35 @@ mod tests {.collect::<Vec<_>>();assert!(args.contains(&"https://example.test/video.mp4".to_string()));}+ #[test]+ fn test_mpv_command_headers_no_broken_ytdl_raw_options() {+ let ua = "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/120.0.0.0 Safari/537.36";+ let headers = vec![+ ("User-Agent".into(), ua.into()),+ ("Referer".into(), "https://4khdhub.one".into()),+ ("Cookie".into(), "auth=token123".into()),+ ];+ let cmd = mpv_command(+ "https://example.test/stream.m3u8",+ None,+ &headers,+ false,+ None,+ None,+ None,+ );+ let args: Vec<String> = cmd+ .get_args()+ .map(|a| a.to_string_lossy().into_owned())+ .collect();+ assert!(args.iter().any(|a| a == &format!("--user-agent={ua}")));+ assert!(args.iter().any(|a| a == "--referrer=https://4khdhub.one"));+ assert!(+ args.iter()+ .any(|a| a == "--http-header-fields=Cookie: auth=token123")+ );+ assert!(!args.iter().any(|a| a.starts_with("--ytdl-raw-options=")));+ }#[test]fn test_detect_prioritizes_android_intent_on_termux() {