Skip to content

Node.js based forum software built for the modern web

38.8 KB
Raw Blame
'use strict';

const assert = require('assert');
const nconf = require('nconf');
const path = require('path');
const fs = require('fs').promises;

const db = require('./mocks/databasemock');
const categories = require('../src/categories');
const topics = require('../src/topics');
const posts = require('../src/posts');
const user = require('../src/user');
const groups = require('../src/groups');
const privileges = require('../src/privileges');
const meta = require('../src/meta');
const socketUser = require('../src/socket.io/user');
const helpers = require('./helpers');
const file = require('../src/file');
const image = require('../src/image');
const uploads = require('../src/middleware/uploads');
const request = require('../src/request');

const emptyUploadsFolder = async () => {
	const files = await fs.readdir(`${nconf.get('upload_path')}/files`);
	await Promise.all(files.map(async (filename) => {
		await file.delete(`${nconf.get('upload_path')}/files/${filename}`);
	}));
};

describe('Upload Controllers', () => {
	let tid;
	let cid;
	let pid;
	let adminUid;
	let regularUid;
	let maliciousUid;

	before(async () => {
		const category = await categories.create({
			name: 'Test Category',
			description: 'Test category created by testing script',
		});
		cid = category.cid;

		adminUid = await user.create({ username: 'admin', password: 'barbar' });
		groups.join('administrators', adminUid);

		regularUid = await user.create({ username: 'regular', password: 'zugzug' });
		maliciousUid = await user.create({ username: 'malicioususer', password: 'herpderp' });

		const result = await topics.post({ uid: adminUid, title: 'test topic title', content: 'test topic content', cid });

		tid = result.topicData.tid;
		pid = result.postData.pid;
	});

	describe('regular user uploads rate limits', () => {
		let jar;
		let csrf_token;

		before(async () => {
			({ jar, csrf_token } = await helpers.loginUser('malicioususer', 'herpderp'));
			await privileges.global.give(['groups:upload:post:file'], 'registered-users');
		});

		it('should fail if the user exceeds the upload rate limit threshold', async () => {
			const oldValue = meta.config.allowedFileExtensions;
			meta.config.allowedFileExtensions = 'png,jpg,bmp,html';
			require('../src/middleware/uploads').clearCache();
			const times = meta.config.uploadRateLimitThreshold + 1;
			for (let i = 0; i < times; i++) {
				// eslint-disable-next-line no-await-in-loop
				const { response, body } = await helpers.uploadFile(`${nconf.get('url')}/api/post/upload`, path.join(__dirname, '../test/files/503.html'), {}, jar, csrf_token);
				if (i + 1 >= times) {
					assert.strictEqual(response.statusCode, 500, JSON.stringify(body));
					assert.strictEqual(body.error, '[[error:upload-ratelimit-reached]]');
				} else {
					assert.strictEqual(response.statusCode, 200, JSON.stringify(body));
					assert(body && body.status && body.response && body.response.images);
					assert(Array.isArray(body.response.images));
					assert(body.response.images[0].url);
				}
			}
			meta.config.allowedFileExtensions = oldValue;
		});
	});

	describe('regular user uploads', () => {
		let jar;
		let csrf_token;

		before(async () => {
			meta.config.uploadRateLimitThreshold = 1000;
			({ jar, csrf_token } = await helpers.loginUser('regular', 'zugzug'));
			await privileges.global.give(['groups:upload:post:file'], 'registered-users');
		});

		it('should upload an image to a post', async () => {
			const { response, body } = await helpers.uploadFile(`${nconf.get('url')}/api/post/upload`, path.join(__dirname, '../test/files/test.png'), {}, jar, csrf_token);
			assert.equal(response.statusCode, 200);
			assert(body && body.status && body.response && body.response.images);
			assert(Array.isArray(body.response.images));
			assert(body.response.images[0].url);
			assert.deepStrictEqual(Object.keys(body.response.images[0]), ['url', 'name']);
		});

		it('should upload an image with -resized.png in its filename', async () => {
			const { response, body } = await helpers.uploadFile(`${nconf.get('url')}/api/post/upload`, path.join(__dirname, '../test/files/test-resized.png'), {}, jar, csrf_token);
			assert.equal(response.statusCode, 200);
			const image = body.response.images[0];
			// image name is unchanged
			assert.strictEqual(image.name, 'test-resized.png');
			// saved file has no -resized at the end ie test-resized.png becomes test.png
			assert(image.url.endsWith('-test.png'));
			// user record doesn't have -resized at the end
			const [userUpload] = await db.getSortedSetRevRange(`uid:${regularUid}:uploads`, 0, 0);
			assert(image.url.endsWith(userUpload), userUpload);
		});

		it('should upload an svg image to a post', async () => {
			const oldValue = meta.config.allowedFileExtensions;
			meta.config.allowedFileExtensions = 'png,jpg,bmp,html,svg';
			const { response, body } = await helpers.uploadFile(`${nconf.get('url')}/api/post/upload`, path.join(__dirname, '../test/files/nodebb.svg'), {}, jar, csrf_token);
			assert.equal(response.statusCode, 200);
			assert(body && body.status && body.response && body.response.images);
			assert(Array.isArray(body.response.images));
			assert(body.response.images[0].url);
			assert.deepStrictEqual(Object.keys(body.response.images[0]), ['url', 'name']);
			meta.config.allowedFileExtensions = oldValue;
		});

		it('should upload an image to a post and then delete the upload', async () => {
			const { response, body } = await helpers.uploadFile(`${nconf.get('url')}/api/post/upload`, path.join(__dirname, '../test/files/test.png'), {}, jar, csrf_token);

			assert.strictEqual(response.statusCode, 200);
			assert(body && body.status && body.response && body.response.images);
			assert(Array.isArray(body.response.images));
			assert(body.response.images[0].url);
			const name = body.response.images[0].url.replace(`${nconf.get('relative_path') + nconf.get('upload_url')}`, '');
			await socketUser.deleteUpload({ uid: regularUid }, { uid: regularUid, name: name });

			const uploads = await db.getSortedSetRange(`uid:${regularUid}:uploads`, 0, -1);
			assert.equal(uploads.includes(name), false);
		});

		it('should not allow deleting if path is not correct', (done) => {
			socketUser.deleteUpload({ uid: adminUid }, { uid: regularUid, name: '../../bkconfig.json' }, (err) => {
				assert.equal(err.message, '[[error:invalid-path]]');
				done();
			});
		});

		it('should not allow deleting if path is not correct', (done) => {
			socketUser.deleteUpload({ uid: adminUid }, { uid: regularUid, name: '/files/../../bkconfig.json' }, (err) => {
				assert.equal(err.message, '[[error:invalid-path]]');
				done();
			});
		});

		it('should resize and upload an image to a post', async () => {
			const oldValue = meta.config.resizeImageWidth;
			meta.config.resizeImageWidth = 10;
			meta.config.resizeImageWidthThreshold = 10;
			const { response, body } = await helpers.uploadFile(`${nconf.get('url')}/api/post/upload`, path.join(__dirname, '../test/files/test.png'), {}, jar, csrf_token);

			assert.equal(response.statusCode, 200);
			assert(body && body.status && body.response && body.response.images);
			assert(Array.isArray(body.response.images));
			assert(body.response.images[0].url);
			assert(body.response.images[0].url.match(/\/assets\/uploads\/files\/\d+-test-resized\.png/));
			meta.config.resizeImageWidth = oldValue;
			meta.config.resizeImageWidthThreshold = 2000;
		});

		it('should resize and upload an image to a post and replace original', async () => {
			const oldValue = meta.config.resizeImageWidth;
			const keepOldValue = meta.config.resizeImageKeepOriginal;
			meta.config.resizeImageWidth = 10;
			meta.config.resizeImageWidthThreshold = 10;
			meta.config.resizeImageKeepOriginal = 0;
			const { response, body } = await helpers.uploadFile(`${nconf.get('url')}/api/post/upload`, path.join(__dirname, '../test/files/test.png'), {}, jar, csrf_token);

			assert.equal(response.statusCode, 200);
			assert(body && body.status && body.response && body.response.images);
			assert(Array.isArray(body.response.images));
			assert(body.response.images[0].url);
			assert(body.response.images[0].url.match(/\/assets\/uploads\/files\/\d+-test.png/));
			meta.config.resizeImageWidth = oldValue;
			meta.config.resizeImageWidthThreshold = 2000;
			meta.config.resizeImageKeepOriginal = keepOldValue;
		});

		it('should upload a file to a post', async () => {
			const oldValue = meta.config.allowedFileExtensions;
			meta.config.allowedFileExtensions = 'png,jpg,bmp,html';
			const { response, body } = await helpers.uploadFile(`${nconf.get('url')}/api/post/upload`, path.join(__dirname, '../test/files/503.html'), {}, jar, csrf_token);
			meta.config.allowedFileExtensions = oldValue;

			assert.strictEqual(response.statusCode, 200);
			assert(body && body.status && body.response && body.response.images);
			assert(Array.isArray(body.response.images));
			assert(body.response.images[0].url);
			assert.deepStrictEqual(Object.keys(body.response.images[0]), ['url', 'name']);
		});

		it('should keep the original name when the file has no extension', async () => {
			const oldValue = meta.config.allowedFileExtensions;
			meta.config.allowedFileExtensions = '';
			const { response, body } = await helpers.uploadFile(`${nconf.get('url')}/api/post/upload`, path.join(__dirname, '../test/files/noextension'), {}, jar, csrf_token);
			meta.config.allowedFileExtensions = oldValue;

			assert.strictEqual(response.statusCode, 200);
			assert(body.response.images[0].url.endsWith('-noextension'));
		});

		it('should upload a file with utf8 characters in the name to a post', async () => {
			const { body } = await helpers.uploadFile(`${nconf.get('url')}/api/post/upload`, path.join(__dirname, '../test/files/测试.jpg'), {}, jar, csrf_token);

			assert(body.response.images[0].url.endsWith('测试.jpg'));
		});

		it('should block encoded private upload paths for unauthenticated users', async () => {
			const oldPrivateUploads = meta.config.privateUploads;
			const oldPrivateUploadsExtensions = meta.config.privateUploadsExtensions;
			const oldAllowedFileExtensions = meta.config.allowedFileExtensions;
			meta.config.privateUploads = 1;
			meta.config.privateUploadsExtensions = '';
			meta.config.allowedFileExtensions = 'png,jpg,bmp,html';

			try {
				const { response: uploadResponse, body: uploadBody } = await helpers.uploadFile(
					`${nconf.get('url')}/api/post/upload`,
					path.join(__dirname, '../test/files/503.html'),
					{},
					jar,
					csrf_token
				);

				assert.strictEqual(uploadResponse.statusCode, 200);
				assert(uploadBody?.response?.images?.[0]?.url);

				const fileUrl = uploadBody.response.images[0].url;
				const directUrl = new URL(fileUrl, nconf.get('base_url')).href;
				const encodedUrl = new URL(fileUrl.replace('/files/', '/%66iles/'), nconf.get('base_url')).href;

				const { response: directResponse } = await request.get(directUrl);
				assert.strictEqual(directResponse.statusCode, 403);

				const { response: encodedResponse } = await request.get(encodedUrl);
				assert.strictEqual(encodedResponse.statusCode, 403);
			} finally {
				meta.config.privateUploads = oldPrivateUploads;
				meta.config.privateUploadsExtensions = oldPrivateUploadsExtensions;
				meta.config.allowedFileExtensions = oldAllowedFileExtensions;
			}
		});

		it('should block percent-encoded private extensions for unauthenticated users', async () => {
			const oldPrivateUploads = meta.config.privateUploads;
			const oldPrivateUploadsExtensions = meta.config.privateUploadsExtensions;
			const uploadPath = nconf.get('upload_path');
			const filename = `private-ext-${Date.now()}.pdf`;
			const filePath = path.join(uploadPath, 'files', filename);

			meta.config.privateUploads = 1;
			meta.config.privateUploadsExtensions = 'pdf';

			try {
				await fs.writeFile(filePath, 'PDFSECRET', 'utf8');

				const relativePath = nconf.get('relative_path') || '';
				const publicPath = `${relativePath}/assets/uploads/files/${filename}`;
				const directUrl = new URL(publicPath, nconf.get('base_url')).href;
				const encodedExtensionUrl = new URL(publicPath.replace(/\.pdf$/, '.%70df'), nconf.get('base_url')).href;

				const { response: directResponse } = await request.get(directUrl);
				assert.strictEqual(directResponse.statusCode, 403);

				const { response: encodedResponse } = await request.get(encodedExtensionUrl);
				assert.strictEqual(encodedResponse.statusCode, 403);
			} finally {
				await file.delete(filePath);
				meta.config.privateUploads = oldPrivateUploads;
				meta.config.privateUploadsExtensions = oldPrivateUploadsExtensions;
			}
		});

		it('should block NTFS stream ::$DATA and . bypass', async () => {
			const oldPrivateUploads = meta.config.privateUploads;
			const oldPrivateUploadsExtensions = meta.config.privateUploadsExtensions;
			const uploadPath = nconf.get('upload_path');
			const filename = `private-ext-${Date.now()}.pdf`;
			const filePath = path.join(uploadPath, 'files', filename);

			meta.config.privateUploads = 1;
			meta.config.privateUploadsExtensions = 'pdf';

			try {
				await fs.writeFile(filePath, 'PDFSECRET', 'utf8');

				const relativePath = nconf.get('relative_path') || '';
				const publicPath = `${relativePath}/assets/uploads/files/${filename}`;
				const directUrl = new URL(publicPath, nconf.get('base_url')).href;
				const streamUrl = new URL(publicPath.replace(/\.pdf$/, '.pdf::$DATA'), nconf.get('base_url')).href;
				const percentEncoded = new URL(publicPath.replace(/\.pdf$/, '.pdf%3A%3A%24DATA'), nconf.get('base_url')).href;
				const extraDot = new URL(publicPath.replace(/\.pdf$/, '.pdf.'), nconf.get('base_url')).href;
				const extraDotEncoded = new URL(publicPath.replace(/\.pdf$/, '.pdf%2E'), nconf.get('base_url')).href;
				const space = new URL(publicPath.replace(/\.pdf$/, '.pdf '), nconf.get('base_url')).href;
				const spaceEncoded = new URL(publicPath.replace(/\.pdf$/, '.pdf%20'), nconf.get('base_url')).href;

				const { response: directResponse } = await request.get(directUrl);
				assert.strictEqual(directResponse.statusCode, 403, `Failed for url: ${directUrl}`);

				const { response: streamResponse } = await request.get(streamUrl);
				assert.strictEqual(streamResponse.statusCode, 403, `Failed for url: ${streamUrl}`);

				const { response: percentEncodedResponse } = await request.get(percentEncoded);
				assert.strictEqual(percentEncodedResponse.statusCode, 403, `Failed for url: ${percentEncoded}`);

				const { response: extraDotResponse } = await request.get(extraDot);
				assert.strictEqual(extraDotResponse.statusCode, 403, `Failed for url: ${extraDot}`);

				const { response: extraDotEncodedResponse } = await request.get(extraDotEncoded);
				assert.strictEqual(extraDotEncodedResponse.statusCode, 403, `Failed for url: ${extraDotEncoded}`);

				const { response: spaceResponse } = await request.get(space);
				assert.strictEqual(spaceResponse.statusCode, 403, `Failed for url: ${space}`);

				const { response: spaceEncodedResponse } = await request.get(spaceEncoded);
				assert.strictEqual(spaceEncodedResponse.statusCode, 403, `Failed for url: ${spaceEncoded}`);
			} finally {
				await file.delete(filePath);
				meta.config.privateUploads = oldPrivateUploads;
				meta.config.privateUploadsExtensions = oldPrivateUploadsExtensions;
			}
		});

		it('should block path traversal and double slashes for unauthenticated users', async () => {
			const oldPrivateUploads = meta.config.privateUploads;
			const oldPrivateUploadsExtensions = meta.config.privateUploadsExtensions;
			const uploadPath = nconf.get('upload_path');
			const filename = `private-ext-${Date.now()}.pdf`;
			const filePath = path.join(uploadPath, 'files', filename);

			meta.config.privateUploads = 1;
			meta.config.privateUploadsExtensions = 'pdf';

			try {
				await fs.writeFile(filePath, 'PDFSECRET', 'utf8');

				const requestPathsToCheck = [
					`/assets/uploads//files/${filename}`,
					`/assets/uploads///files/${filename}`,
					`/assets/uploads/../uploads/files/${filename}`,
					`/assets/uploads/./files/${filename}`,
					`/assets/x/../uploads/files/${filename}`,
					`/assets/uploads/%2e%2e/uploads/files/${filename}`,
					`/assets/uploads/%2e/files/${filename}`,
					`/assets/uploads%5cfiles%5c${filename}`,
					`/assets/uploads/files/test-%G1.pdf`, // invalid percent encoding, should be blocked
				];
				for (const p of requestPathsToCheck) {
					// eslint-disable-next-line no-await-in-loop
					const { response: encodedResponse } = await request.get(`${nconf.get('url')}${p}`);
					assert.strictEqual(encodedResponse.statusCode, 403, `Failed for path: ${p}`);
				}
			} finally {
				await file.delete(filePath);
				meta.config.privateUploads = oldPrivateUploads;
				meta.config.privateUploadsExtensions = oldPrivateUploadsExtensions;
			}
		});


		it('should fail to upload image to post if image dimensions are too big', async () => {
			const { response, body } = await helpers.uploadFile(`${nconf.get('url')}/api/post/upload`, path.join(__dirname, '../test/files/toobig.png'), {}, jar, csrf_token);
			assert.strictEqual(response.statusCode, 500);
			assert(body && body.status && body.status.message);
			assert.strictEqual(body.status.message, 'Image dimensions are too big');
		});

		it('should fail to upload image to post if image is broken', async () => {
			const { response, body } = await helpers.uploadFile(`${nconf.get('url')}/api/post/upload`, path.join(__dirname, '../test/files/brokenimage.png'), {}, jar, csrf_token);
			assert.strictEqual(response.statusCode, 500);
			assert(body && body.status && body.status.message);
		});

		it('should fail to upload file if extension is not allowed', async () => {
			const oldValue = meta.config.allowedFileExtensions;
			meta.config.allowedFileExtensions = 'png,jpg,bmp';

			try {
				const uploadEndPoint = `${nconf.get('url')}/api/post/upload`;
				const form = new FormData();
				const uploadedFile = await fs.readFile(path.join(__dirname, '../test/files/503.html'));
				const blob = new Blob([uploadedFile], { type: 'image/png' });

				form.append('files[]', blob, '503.html');

				const response = await fetch(uploadEndPoint, {
					method: 'post',
					body: form,
					headers: {
						'x-csrf-token': csrf_token,
						cookie: await jar.getCookieString(uploadEndPoint),
					},
				});
				const body = await response.json();

				assert.strictEqual(response.status, 500);
				assert.strictEqual(body?.status?.message, 'Invalid file type .html. Allowed types are: .png, .jpg, .bmp, .jpeg');
			} finally {
				meta.config.allowedFileExtensions = oldValue;
			}
		});

		it('should fail if file is not an image', (done) => {
			image.isFileTypeAllowed(path.join(__dirname, '../test/files/notanimage.png'), (err) => {
				assert.strictEqual(err.message, 'Input file contains unsupported image format');
				done();
			});
		});

		it('should fail if file is not an image', (done) => {
			image.isFileTypeAllowed(path.join(__dirname, '../test/files/notanimage.png'), (err) => {
				assert.strictEqual(err.message, 'Input file contains unsupported image format');
				done();
			});
		});

		it('should fail if file is not an image', (done) => {
			image.size(path.join(__dirname, '../test/files/notanimage.png'), (err) => {
				assert.strictEqual(err.message, 'Input file contains unsupported image format');
				done();
			});
		});

		it('should fail if file is missing', (done) => {
			image.size(path.join(__dirname, '../test/files/doesnotexist.png'), (err) => {
				assert(err.message.startsWith('Input file is missing'));
				done();
			});
		});

		it('should not allow non image uploads', (done) => {
			socketUser.updateCover({ uid: 1 }, { uid: 1, file: { path: '../../text.txt' } }, (err) => {
				assert.equal(err.message, '[[error:invalid-data]]');
				done();
			});
		});

		it('should not allow non image uploads', (done) => {
			socketUser.updateCover({ uid: 1 }, { uid: 1, imageData: 'data:text/html;base64,PHN2Zy9vbmxvYWQ9YWxlcnQoMik+' }, (err) => {
				assert.equal(err.message, '[[error:invalid-image]]');
				done();
			});
		});

		it('should not allow svg uploads', (done) => {
			socketUser.updateCover({ uid: 1 }, { uid: 1, imageData: 'data:image/svg;base64,PHN2Zy9vbmxvYWQ9YWxlcnQoMik+' }, (err) => {
				assert.equal(err.message, '[[error:invalid-image]]');
				done();
			});
		});

		it('should not allow non image uploads', (done) => {
			socketUser.uploadCroppedPicture({ uid: 1 }, { uid: 1, file: { path: '../../text.txt' } }, (err) => {
				assert.equal(err.message, '[[error:invalid-data]]');
				done();
			});
		});

		it('should not allow non image uploads', (done) => {
			socketUser.uploadCroppedPicture({ uid: 1 }, { uid: 1, imageData: 'data:text/html;base64,PHN2Zy9vbmxvYWQ9YWxlcnQoMik+' }, (err) => {
				assert.equal(err.message, '[[error:invalid-image]]');
				done();
			});
		});

		it('should not allow svg uploads', (done) => {
			socketUser.uploadCroppedPicture({ uid: 1 }, { uid: 1, imageData: 'data:image/svg;base64,PHN2Zy9vbmxvYWQ9YWxlcnQoMik+' }, (err) => {
				assert.equal(err.message, '[[error:invalid-image]]');
				done();
			});
		});

		it('should return default cover for invalid cover:url when user profile is loaded', async () => {
			await user.setUserField(1, 'cover:url', 'http://example.com/"><script>alert(1)</script>');
			const { body: userData } = await helpers.request('get', '/api/user/admin');
			assert.strictEqual(userData['cover:url'], `${nconf.get('relative_path')}/assets/images/cover-default.png`);
		});

		it('should return empty string for invalid picture when user profile is loaded', async () => {
			await user.setUserField(1, 'picture', 'http://example.com/"><script>alert(1)</script>');
			const { body: userData } = await helpers.request('get', '/api/user/admin');
			assert.strictEqual(userData['picture'], '');
		});

		it('should delete users uploads if account is deleted', async () => {
			const uid = await user.create({ username: 'uploader', password: 'barbar' });
			const file = require('../src/file');
			const data = await helpers.loginUser('uploader', 'barbar');
			const { body } = await helpers.uploadFile(`${nconf.get('url')}/api/post/upload`, path.join(__dirname, '../test/files/test.png'), {}, data.jar, data.csrf_token);

			assert(body && body.status && body.response && body.response.images);
			assert(Array.isArray(body.response.images));
			assert(body.response.images[0].url);
			const { url } = body.response.images[0];

			await user.delete(1, uid);

			const filePath = path.join(nconf.get('upload_path'), url.replace('/assets/uploads', ''));
			const exists = await file.exists(filePath);
			assert(!exists);
		});

		after(emptyUploadsFolder);
	});

	describe('admin uploads', () => {
		let jar;
		let csrf_token;
		let regularJar;
		let regular_csrf_token;

		before(async () => {
			({ jar, csrf_token } = await helpers.loginUser('admin', 'barbar'));
			const regularLogin = await helpers.loginUser('regular', 'zugzug');
			regularJar = regularLogin.jar;
			regular_csrf_token = regularLogin.csrf_token;
		});

		it('should upload site logo', async () => {
			const { response, body } = await helpers.uploadFile(`${nconf.get('url')}/api/admin/uploadlogo`, path.join(__dirname, '../test/files/test.png'), {}, jar, csrf_token);
			assert.strictEqual(response.statusCode, 200);
			assert(Array.isArray(body));
			assert.equal(body[0].url, `${nconf.get('relative_path')}/assets/uploads/system/site-logo.png`);
		});

		it('should fail to upload invalid file type', async () => {
			const { response, body } = await helpers.uploadFile(
				`${nconf.get('url')}/api/admin/category/uploadpicture`,
				path.join(__dirname, '../test/files/503.html'),
				{ params: JSON.stringify({ cid: cid }) },
				jar,
				csrf_token
			);
			assert.strictEqual(response.statusCode, 500);
			assert.equal(body.error, '[[error:invalid-image-type, text/html, image/png&#44; image/jpeg&#44; image/pjpeg&#44; image/jpg&#44; image/gif&#44; image/svg+xml]]');
		});

		it('should fail to upload category image with invalid json params', async () => {
			const { response, body } = await helpers.uploadFile(`${nconf.get('url')}/api/admin/category/uploadpicture`, path.join(__dirname, '../test/files/test.png'), { params: 'invalid json' }, jar, csrf_token);
			assert.strictEqual(response.statusCode, 500);
			assert.equal(body.error, '[[error:invalid-json]]');
		});

		it('should upload category image', async () => {
			const { response, body } = await helpers.uploadFile(`${nconf.get('url')}/api/admin/category/uploadpicture`, path.join(__dirname, '../test/files/test.png'), { params: JSON.stringify({ cid: cid }) }, jar, csrf_token);
			assert.equal(response.statusCode, 200);
			assert(Array.isArray(body));
			assert.equal(body[0].url, `${nconf.get('relative_path')}/assets/uploads/category/category-1.png`);
		});

		it('should upload svg as category image after cleaning it up', async () => {
			const { response, body } = await helpers.uploadFile(`${nconf.get('url')}/api/admin/category/uploadpicture`, path.join(__dirname, '../test/files/dirty.svg'), { params: JSON.stringify({ cid: cid }) }, jar, csrf_token);
			assert.equal(response.statusCode, 200);
			assert(Array.isArray(body));
			assert.equal(body[0].url, `${nconf.get('relative_path')}/assets/uploads/category/category-1.svg`);
			const svgContents = await fs.readFile(path.join(__dirname, '../test/uploads/category/category-1.svg'), 'utf-8');
			assert.strictEqual(svgContents.includes('<script>'), false);
		});

		it('should upload default avatar', async () => {
			const { response, body } = await helpers.uploadFile(`${nconf.get('url')}/api/admin/uploadDefaultAvatar`, path.join(__dirname, '../test/files/test.png'), { }, jar, csrf_token);
			assert.equal(response.statusCode, 200);
			assert.equal(body[0].url, `${nconf.get('relative_path')}/assets/uploads/system/avatar-default.png`);
		});

		it('should upload og image', async () => {
			const { response, body } = await helpers.uploadFile(`${nconf.get('url')}/api/admin/uploadOgImage`, path.join(__dirname, '../test/files/test.png'), { }, jar, csrf_token);
			assert.equal(response.statusCode, 200);
			assert.equal(body[0].url, `${nconf.get('relative_path')}/assets/uploads/system/og-image.png`);
		});

		it('should upload favicon', async () => {
			const { response, body } = await helpers.uploadFile(
				`${nconf.get('url')}/api/admin/uploadfavicon`,
				path.join(__dirname, '../test/files/favicon.ico'), {}, jar, csrf_token
			);
			assert.equal(response.statusCode, 200);
			assert(Array.isArray(body));
			assert.equal(body[0].url, `${nconf.get('relative_path')}/assets/uploads/system/favicon.ico`);
		});

		it('should upload touch icon', async () => {
			const touchiconAssetPath = '/assets/uploads/system/touchicon-orig.png';
			const { response, body } = await helpers.uploadFile(
				`${nconf.get('url')}/api/admin/uploadTouchIcon`,
				path.join(__dirname, '../test/files/test.png'),
				{},
				jar,
				csrf_token
			);

			assert.equal(response.statusCode, 200);
			assert(Array.isArray(body));
			assert.equal(body[0].url, touchiconAssetPath);
			meta.config['brand:touchIcon'] = touchiconAssetPath;
			const { response: res1, body: body1 } = await request.get(`${nconf.get('url')}/apple-touch-icon`);
			assert.equal(res1.statusCode, 200);
			assert(body1);
		});

		it('should upload regular file', async () => {
			const { response, body } = await helpers.uploadFile(`${nconf.get('url')}/api/admin/upload/file`, path.join(__dirname, '../test/files/test.png'), {
				params: JSON.stringify({
					folder: 'system',
				}),
			}, jar, csrf_token);

			assert.equal(response.statusCode, 200);
			assert(Array.isArray(body));
			assert.equal(body[0].url, '/assets/uploads/system/test.png');
			assert(file.existsSync(path.join(nconf.get('upload_path'), 'system', 'test.png')));
		});

		it('should sanitize xss payload in uploaded xml files', async () => {
			const { response, body } = await helpers.uploadFile(`${nconf.get('url')}/api/admin/upload/file`, path.join(__dirname, '../test/files/xss-dirty.xml'), {
				params: JSON.stringify({
					folder: 'files',
				}),
			}, jar, csrf_token);

			assert.equal(response.statusCode, 200);
			assert(Array.isArray(body));
			assert.equal(body[0].url, '/assets/uploads/files/xss-dirty.xml');

			const { response: fileResponse, body: uploadedBody } = await request.get(`${nconf.get('url')}${body[0].url}`);
			assert.equal(fileResponse.statusCode, 200);
			assert.strictEqual(uploadedBody.includes('<script>'), false);
			assert.strictEqual(uploadedBody.includes('onload="alert(\'XSS\')"'), false);
			assert.strictEqual(uploadedBody.includes('<a:script>'), false);
			assert.strictEqual(uploadedBody.includes('JAVASCRIPT:alert(1)'), false);
		});

		it('should set content-disposition header to attachment for xml', async () => {
			const { response, body } = await helpers.uploadFile(`${nconf.get('url')}/api/admin/upload/file`, path.join(__dirname, '../test/files/xss-dirty.xml'), {
				params: JSON.stringify({
					folder: '',
				}),
			}, jar, csrf_token);

			assert.equal(body[0].url, '/assets/uploads/xss-dirty.xml');
			const urlsToTest = [
				body[0].url,
				`/assets/../assets/uploads//xss-dirty.xml`,
				`/assets/uploads///xss-dirty.xml`,
				`/assets/uploads/../uploads/xss-dirty.xml`,
				`/assets/uploads/./xss-dirty.xml`,
				`/assets/x/../uploads/xss-dirty.xml`,
				`/assets/uploads/%2e%2e/uploads/xss-dirty.xml`,
				`/assets/uploads/%2e/xss-dirty.xml`,
				`/assets/uploads/xss-dirty.xml `,
			];

			const urlsTo403 = [
				`/assets/uploads/xss-dirty.xml::$DATA`,
				`/assets/uploads/xss-dirty.xml%3A%3A%24DATA`,
				`/assets/uploads/xss-dirty.xml.`,
				`/assets/uploads/xss-dirty.xml%2E`,
				`/assets/uploads/xss-dirty.xml%20`,
			];

			for (const url of urlsToTest) {
				// eslint-disable-next-line no-await-in-loop
				const { response: fileResponse } = await request.get(`${nconf.get('url')}${url}`);
				assert.equal(fileResponse.statusCode, 200, `Failed for url: ${url}`);
				assert.strictEqual(fileResponse.headers['content-disposition'], 'attachment; filename="xss-dirty.xml"', `Failed for url: ${url}`);
			}

			for (const url of urlsTo403) {
				// eslint-disable-next-line no-await-in-loop
				const { response: fileResponse } = await request.get(`${nconf.get('url')}${url}`);
				assert.equal(fileResponse.statusCode, 403, `Failed for url: ${url}`);
			}
		});

		it('should keep valid xml file unchanged', async () => {
			const validXmlPath = path.join(__dirname, '../test/files/xss-valid.xml');
			const validXmlContent = await fs.readFile(validXmlPath, 'utf-8');
			const { response, body } = await helpers.uploadFile(`${nconf.get('url')}/api/admin/upload/file`, validXmlPath, {
				params: JSON.stringify({
					folder: 'files',
				}),
			}, jar, csrf_token);

			assert.equal(response.statusCode, 200);
			assert(Array.isArray(body));
			assert.equal(body[0].url, '/assets/uploads/files/xss-valid.xml');

			const { response: fileResponse, body: uploadedBody } = await request.get(`${nconf.get('url')}${body[0].url}`);
			assert.equal(fileResponse.statusCode, 200);
			assert.strictEqual(uploadedBody, validXmlContent);
		});

		it('should fail to upload regular file in wrong directory', async () => {
			const { response, body } = await helpers.uploadFile(`${nconf.get('url')}/api/admin/upload/file`, path.join(__dirname, '../test/files/test.png'), {
				params: JSON.stringify({
					folder: '../../system',
				}),
			}, jar, csrf_token);

			assert.equal(response.statusCode, 500);
			assert.strictEqual(body.error, '[[error:invalid-path]]');
		});

		it('should fail to upload regular file to an existing directory outside of upload_path', async () => {
			const { response, body } = await helpers.uploadFile(`${nconf.get('url')}/api/admin/upload/file`, path.join(__dirname, '../test/files/test.png'), {
				params: JSON.stringify({
					folder: '../',
				}),
			}, jar, csrf_token);

			assert.equal(response.statusCode, 500);
			assert.strictEqual(body.error, '[[error:invalid-path]]');
		});

		it('should fail to upload regular file if directory does not exist', async () => {
			const { response, body } = await helpers.uploadFile(`${nconf.get('url')}/api/admin/upload/file`, path.join(__dirname, '../test/files/test.png'), {
				params: JSON.stringify({
					folder: 'does-not-exist',
				}),
			}, jar, csrf_token);

			assert.equal(response.statusCode, 500);
			assert.strictEqual(body.error, '[[error:invalid-path]]');
		});

		describe('ACP uploads screen', () => {
			it('should create a folder', async () => {
				const { response } = await helpers.createFolder('', 'myfolder', jar, csrf_token);
				assert.strictEqual(response.statusCode, 200);
				assert(file.existsSync(path.join(nconf.get('upload_path'), 'myfolder')));
			});

			it('should fail to create a folder if it already exists', async () => {
				const { response, body } = await helpers.createFolder('', 'myfolder', jar, csrf_token);
				assert.strictEqual(response.statusCode, 403);
				assert.deepStrictEqual(body.status, {
					code: 'forbidden',
					message: 'Folder exists',
				});
			});

			it('should fail to create a folder as a non-admin', async () => {
				const { response, body } = await helpers.createFolder('', 'hisfolder', regularJar, regular_csrf_token);
				assert.strictEqual(response.statusCode, 403);
				assert.deepStrictEqual(body.status, {
					code: 'forbidden',
					message: 'You are not authorised to make this call',
				});
			});

			it('should fail to create a folder in wrong directory', async () => {
				const { response, body } = await helpers.createFolder('../traversing', 'unexpectedfolder', jar, csrf_token);
				assert.strictEqual(response.statusCode, 403);
				assert.deepStrictEqual(body.status, {
					code: 'forbidden',
					message: 'Invalid path',
				});
			});

			it('should use basename of given folderName to create new folder', async () => {
				const { response } = await helpers.createFolder('/myfolder', '../another folder', jar, csrf_token);
				assert.strictEqual(response.statusCode, 200);
				const slugifiedName = 'another-folder';
				assert(file.existsSync(path.join(nconf.get('upload_path'), 'myfolder', slugifiedName)));
			});

			it('should fail to delete a file as a non-admin', async () => {
				const { response, body } = await request.delete(`${nconf.get('url')}/api/v3/files`, {
					body: {
						path: '/system/test.png',
					},
					jar: regularJar,
					headers: {
						'x-csrf-token': regular_csrf_token,
					},
				});
				assert.strictEqual(response.statusCode, 403);
				assert.deepStrictEqual(body.status, {
					code: 'forbidden',
					message: 'You are not authorised to make this call',
				});
			});
		});

		after(emptyUploadsFolder);
	});

	describe('middleware.setSafeFileHeaders()', () => {
		function mockRes() {
			const headers = {};
			return {
				headers,
				setHeader(name, value) {
					headers[name.toLowerCase()] = value;
					return this;
				},
				attachment(filename) {
					this.setHeader('Content-Disposition', `attachment; filename="${filename}"`);
					return this;
				},
			};
		}

		it('should always set X-Content-Type-Options: nosniff', () => {
			const res = mockRes();
			uploads.setSafeFileHeaders(res, 'test.png');
			assert.strictEqual(res.headers['x-content-type-options'], 'nosniff');
		});

		it('should force a download for unsafe extensions (SVG)', () => {
			const res = mockRes();
			uploads.setSafeFileHeaders(res, 'pwn.svg');
			assert.strictEqual(res.headers['content-disposition'], 'attachment; filename="pwn.svg"');
		});

		it('should not force a download for safe image extensions', () => {
			const res = mockRes();
			uploads.setSafeFileHeaders(res, 'test.png');
			assert.strictEqual(res.headers['content-disposition'], undefined);
		});
	});

	describe('library methods', () => {
		describe('.getOrphans()', () => {
			before(async () => {
				const { jar, csrf_token } = await helpers.loginUser('regular', 'zugzug');
				await helpers.uploadFile(`${nconf.get('url')}/api/post/upload`, path.join(__dirname, '../test/files/test.png'), {}, jar, csrf_token);
			});

			it('should return files with no post associated with them', async () => {
				const orphans = await posts.uploads.getOrphans();

				assert.strictEqual(orphans.length, 1);
				orphans.forEach((relPath) => {
					assert(relPath.startsWith('/files/'));
					assert(relPath.endsWith('test.png'));
				});
			});

			after(emptyUploadsFolder);
		});

		describe('.cleanOrphans()', () => {
			let _orphanExpiryDays;

			before(async () => {
				const { jar, csrf_token } = await helpers.loginUser('regular', 'zugzug');
				await helpers.uploadFile(`${nconf.get('url')}/api/post/upload`, path.join(__dirname, '../test/files/test.png'), {}, jar, csrf_token);

				// modify all files in uploads folder to be 30 days old
				const files = await fs.readdir(`${nconf.get('upload_path')}/files`);
				const p30d = (Date.now() - (1000 * 60 * 60 * 24 * 30)) / 1000;
				await Promise.all(files.map(async (filename) => {
					await fs.utimes(`${nconf.get('upload_path')}/files/${filename}`, p30d, p30d);
				}));

				_orphanExpiryDays = meta.config.orphanExpiryDays;
			});

			it('should not touch orphans if not configured to do so', async () => {
				await posts.uploads.cleanOrphans();
				const orphans = await posts.uploads.getOrphans();

				assert.strictEqual(orphans.length, 1);
			});

			it('should not touch orphans if they are newer than the configured expiry', async () => {
				meta.config.orphanExpiryDays = 60;
				await posts.uploads.cleanOrphans();
				const orphans = await posts.uploads.getOrphans();

				assert.strictEqual(orphans.length, 1);
			});

			it('should delete orphans older than the configured number of days', async () => {
				meta.config.orphanExpiryDays = 7;
				await posts.uploads.cleanOrphans();
				const orphans = await posts.uploads.getOrphans();

				assert.strictEqual(orphans.length, 0);
			});

			after(async () => {
				await emptyUploadsFolder();
				meta.config.orphanExpiryDays = _orphanExpiryDays;
			});
		});

		describe('.getUploadsForPost() should ignore ? suffixes after file path', () => {
			let relPath;
			const relativePath = nconf.get('relative_path') || '';
			before(async () => {
				const { jar, csrf_token } = await helpers.loginUser('regular', 'zugzug');
				const { body } = await helpers.uploadFile(`${nconf.get('url')}/api/post/upload`, path.join(__dirname, '../test/files/test.png'), {}, jar, csrf_token);
				relPath = body.response.images[0].url.slice(body.response.images[0].url.indexOf('/files/'));
			});

			it('should strip a width x height suffix (?w=1920&h=1080)', async () => {
				const content = `![alt](${relativePath}/assets/uploads${relPath}?w=1920&h=1080)`;
				const uploads = await posts.uploads.getUploadsForPost({ tid: 0, content }, false);
				assert.deepStrictEqual(uploads, [relPath]);
			});

			it('should strip a percentage suffix (?w=50%)', async () => {
				const content = `![alt](${relativePath}/assets/uploads${relPath}?w=50%)`;
				const uploads = await posts.uploads.getUploadsForPost({ tid: 0, content }, false);
				assert.deepStrictEqual(uploads, [relPath]);
			});

			it('should strip a width-only/multiplier suffix (?w=200)', async () => {
				const content = `![alt](${relativePath}/assets/uploads${relPath}?w=200)`;
				const uploads = await posts.uploads.getUploadsForPost({ tid: 0, content }, false);
				assert.deepStrictEqual(uploads, [relPath]);
			});

			after(async () => {
				await emptyUploadsFolder();
			});
		});
	});
});