Skip to content

Node.js based forum software built for the modern web

fix: wrap cached returns for dns lookups in nextTick

Julian Lam010113a9a002
diff --git a/src/request.js b/src/request.js
index aaf0d55b32..fe8de851c1 100644
--- a/src/request.js
+++ b/src/request.js
@@ -58,12 +58,15 @@ function lookup(hostname, options, callback) {
return;
}
- if (options.all === true) {
- callback(null, lookup);
- } else {
- const { address, family } = lookup.shift();
- callback(null, address, family);
- }
+ // Lookup needs to behave asynchronously — https://github.com/nodejs/node/issues/28664
+ process.nextTick(() => {
+ if (options.all === true) {
+ callback(null, lookup);
+ } else {
+ const { address, family } = lookup.shift();
+ callback(null, address, family);
+ }
+ });
}
// Initialize fetch - somewhat hacky, but it's required for globalDispatcher to be available