Skip to content

Node.js based forum software built for the modern web

fix: parse post data when sending notifications when schedule topics are posted

Julian Lam041f3ba77233
diff --git a/src/topics/scheduled.js b/src/topics/scheduled.js
index b6dcba9a74..e16cc71d0d 100644
--- a/src/topics/scheduled.js
+++ b/src/topics/scheduled.js
@@ -120,6 +120,7 @@ async function sendNotifications(uids, topicsData) {
let postsData = await posts.getPostsData(topicsData.map(t => t && t.mainPid));
topicsData = topicsData.filter((t, i) => t && postsData[i]);
postsData = postsData.filter(Boolean);
+ postsData = await Promise.all(postsData.map(p => posts.parsePost(p)));
postsData.forEach((postData, idx) => {
if (postData) {
postData.user = uidToUserData[topicsData[idx].uid];
diff --git a/test/topics.js b/test/topics.js
index 25f3a723ad..9f33627424 100644
--- a/test/topics.js
+++ b/test/topics.js
@@ -2613,6 +2613,33 @@ describe('Topic\'s', () => {
assert(!score);
});
+ it('should sanitize HTML in scheduled topic notification bodyLong', async () => {
+ const followerUid = await User.create({ username: 'xss_follower' });
+ await User.follow(followerUid, adminUid);
+ const maliciousContent = '<script>alert("xss")</script><img onerror=alert(1) src=x><b>Bold</b>';
+ const maliciousTopic = {
+ uid: adminUid,
+ cid: categoryObj.cid,
+ title: 'Malicious Scheduled Topic',
+ content: maliciousContent,
+ timestamp: new Date(Date.now() + 86400000).getTime(),
+ };
+ const result = await topics.post(maliciousTopic);
+
+ // Publish the scheduled topic
+ mockdate.set(result.topicData.timestamp);
+ await topics.scheduled.handleExpired();
+ mockdate.reset();
+
+ // Check that the notification bodyLong is sanitized
+ const notifKey = `notifications:tid:${result.topicData.tid}:uid:${adminUid}`;
+ const notif = await db.getObject(notifKey);
+ assert(notif, 'Notification should exist');
+ assert(!notif.bodyLong.includes('<script>'), 'bodyLong should not contain script tags');
+ assert(!notif.bodyLong.includes('onerror'), 'bodyLong should not contain onerror attributes');
+ assert(notif.bodyLong.includes('Bold'), 'bodyLong should still contain allowed tags like <b>');
+ });
+
it('should properly update timestamp in cid:<cid>:pids after editing and posting immediately', async () => {
const scheduleTimestamp = Date.now() + (86400000 * 365);
const result = await topics.post({