Skip to content

Node.js based forum software built for the modern web

refactor: remove from biweek sorted set as well

Barış Soner Uşaklı0a56c3cedfa1
diff --git a/src/user/digest.js b/src/user/digest.js
index 89301dde85..5b268cd4e3 100644
--- a/src/user/digest.js
+++ b/src/user/digest.js
@@ -58,7 +58,7 @@ Digest.getUsersInterval = async (uids) => {
};
Digest.getSubscribers = async function (interval) {
- let subscribers = [];
+ const subscribers = [];
await batch.processSortedSet('users:joindate', async (uids) => {
const settings = await user.getMultipleUserSettings(uids);
@@ -69,7 +69,7 @@ Digest.getSubscribers = async function (interval) {
}
});
subUids = await user.bans.filterBanned(subUids);
- subscribers = subscribers.concat(subUids);
+ subscribers.push(...subUids);
}, {
interval: 1000,
batch: 500,
diff --git a/src/user/settings.js b/src/user/settings.js
index c3c2213985..7c52d1f2f0 100644
--- a/src/user/settings.js
+++ b/src/user/settings.js
@@ -204,7 +204,9 @@ module.exports = function (User) {
}
User.updateDigestSetting = async function (uid, dailyDigestFreq) {
- await db.sortedSetsRemove(['digest:day:uids', 'digest:week:uids', 'digest:month:uids'], uid);
+ await db.sortedSetsRemove([
+ 'digest:day:uids', 'digest:week:uids', 'digest:biweek:uids', 'digest:month:uids',
+ ], uid);
if (['day', 'week', 'biweek', 'month'].includes(dailyDigestFreq)) {
await db.sortedSetAdd(`digest:${dailyDigestFreq}:uids`, Date.now(), uid);
}