Skip to content

Node.js based forum software built for the modern web

test: explicitly save session before redirecting

Barış Soner Uşaklı0f8a0603eb32
diff --git a/src/controllers/accounts/edit.js b/src/controllers/accounts/edit.js
index 06ac495cf7..82cfa8be5d 100644
--- a/src/controllers/accounts/edit.js
+++ b/src/controllers/accounts/edit.js
@@ -103,7 +103,12 @@ editController.email = async function (req, res, next) {
req.session.registration = req.session.registration || {};
req.session.registration.updateEmail = true;
req.session.registration.uid = targetUid;
- helpers.redirect(res, '/register/complete');
+ req.session.save((err) => {
+ if (err) {
+ return next(err);
+ }
+ helpers.redirect(res, '/register/complete');
+ });
};
async function renderRoute(name, req, res) {
diff --git a/src/controllers/authentication.js b/src/controllers/authentication.js
index 054a18e7de..c256b8681d 100644
--- a/src/controllers/authentication.js
+++ b/src/controllers/authentication.js
@@ -209,8 +209,8 @@ authenticationController.registerAbort = async (req, res) => {
const { interstitials } = await user.interstitials.get(req, req.session.registration);
if (!interstitials.length) {
- delete req.session.registration;
winston.info(`[register/abort] no intersitials ${JSON.stringify({ uid: req.uid, session: req.session })}`);
+ delete req.session.registration;
return res.redirect(nconf.get('relative_path') + (req.session.returnTo || '/'));
}
winston.info(`[register/abort] Found intersitials ${JSON.stringify({ uid: req.uid, session: req.session, interstitials })}`);