Node.js based forum software built for the modern web
fix(activitypub): enforce chat policy in assertPrivate
Julian Lam1528c5414669
diff --git a/src/activitypub/notes.js b/src/activitypub/notes.jsindex 28a5c482af..527a115108 100644--- a/src/activitypub/notes.js+++ b/src/activitypub/notes.js@@ -511,6 +511,22 @@ Notes.assertPrivate = async (object) => {return null;}+ // Local recipients who cannot be messaged should be removed+ const recipientUids = Array.from(recipients).filter(uid => utils.isNumber(uid));+ const results = await Promise.all(recipientUids.map(async (uid) => {+ try {+ await messaging.canMessageUser(payload.uid, uid);+ return { uid, valid: true };+ } catch (e) {+ return { uid, valid: false };+ }+ }));+ const validUids = results.filter(r => r.valid).map(r => r.uid);+ if (validUids.length === 0) {+ return null;+ }+ results.filter(r => !r.valid).forEach(r => recipients.delete(r.uid));+if (!roomId) {roomId = await messaging.newRoom(payload.uid, { uids: [...recipients] });}