Node.js based forum software built for the modern web
fix: bypass self-edit reputation checks for privileged users (#14214)
palmoni5164a3d498ad8
diff --git a/src/controllers/accounts/edit.js b/src/controllers/accounts/edit.jsindex 6c1c977e0d..c02bb7563d 100644--- a/src/controllers/accounts/edit.js+++ b/src/controllers/accounts/edit.js@@ -19,8 +19,6 @@ editController.get = async function (req, res, next) {const {username,userslug,- isSelf,- reputation,groups: _groups,groupTitleArray,allowMultipleBadges,@@ -37,8 +35,8 @@ editController.get = async function (req, res, next) {userData.maximumAboutMeLength = meta.config.maximumAboutMeLength;userData.allowMultipleBadges = meta.config.allowMultipleBadges === 1;userData.allowAccountDelete = meta.config.allowAccountDelete === 1;- userData.allowAboutMe = !isSelf || !!meta.config['reputation:disabled'] || reputation >= meta.config['min:rep:aboutme'];- userData.allowSignature = canUseSignature && (!isSelf || !!meta.config['reputation:disabled'] || reputation >= meta.config['min:rep:signature']);+ userData.allowAboutMe = accountHelpers.meetsMinReputation(userData, 'min:rep:aboutme');+ userData.allowSignature = canUseSignature && accountHelpers.meetsMinReputation(userData, 'min:rep:signature');userData.defaultAvatar = user.getDefaultAvatar();userData.groups = _groups.filter(g => g && g.userTitleEnabled && !groups.isPrivilegeGroup(g.name) && g.name !== 'registered-users');diff --git a/src/controllers/accounts/helpers.js b/src/controllers/accounts/helpers.jsindex ba08f7187b..bb859d1ecf 100644--- a/src/controllers/accounts/helpers.js+++ b/src/controllers/accounts/helpers.js@@ -22,6 +22,13 @@ const relative_path = nconf.get('relative_path');const helpers = module.exports;+helpers.meetsMinReputation = function (userData, setting) {+ return !userData.isSelf ||+ userData.isAdminOrGlobalModerator ||+ !!meta.config['reputation:disabled'] ||+ userData.reputation >= meta.config[setting];+};+helpers.getUserDataByUserSlug = async function (userslug, callerUID, query = {}) {const uid = await user.getUidByUserslug(userslug);if (!uid) {@@ -93,8 +100,8 @@ helpers.getUserDataByUserSlug = async function (userslug, callerUID, query = {})userData.hasPrivateChat = results.hasPrivateChat;userData.iconBackgrounds = results.iconBackgrounds;userData.showHidden = results.canEdit; // remove in v1.19.0- userData.allowProfilePicture = !userData.isSelf || !!meta.config['reputation:disabled'] || userData.reputation >= meta.config['min:rep:profile-picture'];- userData.allowCoverPicture = !userData.isSelf || !!meta.config['reputation:disabled'] || userData.reputation >= meta.config['min:rep:cover-picture'];+ userData.allowProfilePicture = helpers.meetsMinReputation(userData, 'min:rep:profile-picture');+ userData.allowCoverPicture = helpers.meetsMinReputation(userData, 'min:rep:cover-picture');userData.allowProfileImageUploads = meta.config.allowProfileImageUploads;userData.allowedProfileImageExtensions = user.getAllowedProfileImageExtensions().map(ext => `.${ext}`).join(', ');userData.maximumProfileImageSize = meta.config.maximumProfileImageSize;diff --git a/src/user/profile.js b/src/user/profile.jsindex 2a0c187ebc..c45ff04d97 100644--- a/src/user/profile.js+++ b/src/user/profile.js@@ -278,6 +278,9 @@ module.exports = function (User) {if (!isSelf || meta.config['reputation:disabled']) {return;}+ if (await User.isAdminOrGlobalMod(callerUid)) {+ return;+ }const reputation = await User.getUserField(uid, 'reputation');if (reputation < meta.config[setting]) {throw new Error(`[[error:not-enough-reputation-${setting.replace(/:/g, '-')}, ${meta.config[setting]}]]`);