Node.js based forum software built for the modern web
fix: sql injection in sortedSetScan
Barış Soner Uşaklı16504bad8100
diff --git a/src/database/postgres/sorted.js b/src/database/postgres/sorted.jsindex 916425e0c1..9f59224497 100644--- a/src/database/postgres/sorted.js+++ b/src/database/postgres/sorted.js@@ -707,9 +707,9 @@ SELECT z."value",ON o."_key" = z."_key"AND o."type" = z."type"WHERE o."_key" = $1::TEXT- AND z."value" LIKE '${match}'+ AND z."value" LIKE $3LIMIT $2::INTEGER`,- values: [params.key, params.limit],+ values: [params.key, params.limit, match],});if (!params.withScores) {return res.rows.map(r => r.value);diff --git a/test/database/sorted.js b/test/database/sorted.jsindex 33d3e4c4b5..b98d969730 100644--- a/test/database/sorted.js+++ b/test/database/sorted.js@@ -78,6 +78,21 @@ describe('Sorted Set methods', () => {assert(data.includes('ddb'));assert(data.includes('adb'));});++ it('should not error with invalid input', async () => {+ const query = `-3217'+OR 1251=CAST((CHR(113)||CHR(98)||CHR(118)||CHR(98)||CHR(113))||(SELECT+(CASE WHEN (1251=1251) THEN 1 ELSE 0+END))::text||(CHR(113)||CHR(113)||CHR(118)||CHR(98)||CHR(113)) AS+NUMERIC)-- WsPn&query[cid]=-1&parentCid=0&selectedCids[]=-1&privilege=topics:read&states[]=watching&states[]=tracking&states[]=notwatching&showLinks=`;+ const match = `*${query.toLowerCase()}*`;+ const data = await db.getSortedSetScan({+ key: 'categories:name',+ match: match,+ limit: 500,+ });+ assert.strictEqual(data.length, 0);+ });});describe('sortedSetAdd()', () => {