Node.js based forum software built for the modern web
fix: #13668, privilege checking on topic create for remote users; was not properly checking against fediverse pseudo-user
Julian Lam218f5eabe2a2
diff --git a/src/topics/create.js b/src/topics/create.jsindex 2f41c822b1..43001a9bd3 100644--- a/src/topics/create.js+++ b/src/topics/create.js@@ -89,11 +89,12 @@ module.exports = function (Topics) {Topics.post = async function (data) {data = await plugins.hooks.fire('filter:topic.post', data);const { uid } = data;+ const remoteUid = !utils.isNumber(uid);const [categoryExists, canCreate, canTag, isAdmin] = await Promise.all([parseInt(data.cid, 10) > 0 ? categories.exists(data.cid) : true,- privileges.categories.can('topics:create', data.cid, uid),- privileges.categories.can('topics:tag', data.cid, uid),+ privileges.categories.can('topics:create', data.cid, remoteUid ? -2 : uid),+ privileges.categories.can('topics:tag', data.cid, remoteUid ? -2 : uid),privileges.users.isAdministrator(uid),]);