Skip to content

Node.js based forum software built for the modern web

fix: add missing changes in category.js

Barış Soner Uşaklı22f055dee4d6
diff --git a/src/controllers/category.js b/src/controllers/category.js
index e0b84cb3f7..4e1df7acde 100644
--- a/src/controllers/category.js
+++ b/src/controllers/category.js
@@ -121,7 +121,8 @@ categoryController.get = async function (req, res, next) {
categories.flattenCategories(allCategories, categoryData.children);
await helpers.translateCategoryData([categoryData].concat(categoryData.children), userSettings.userLang),
await Promise.all([
- buildBreadcrumbs(req, categoryData),
+ // needs to be after translateCategoryData to ensure category names are translated for breadcrumbs
+ buildBreadcrumbs(req, categoryData, userSettings.userLang),
categories.setUnread([categoryData], allCategories.map(c => c.cid).concat(cid), req.uid),
]);
@@ -187,7 +188,7 @@ categoryController.get = async function (req, res, next) {
res.render('category', categoryData);
};
-async function buildBreadcrumbs(req, categoryData) {
+async function buildBreadcrumbs(req, categoryData, userLang) {
const breadcrumbs = [
{
text: categoryData.name,
@@ -195,7 +196,7 @@ async function buildBreadcrumbs(req, categoryData) {
cid: categoryData.cid,
},
];
- const crumbs = await helpers.buildCategoryBreadcrumbs(categoryData.parentCid);
+ const crumbs = await helpers.buildCategoryBreadcrumbs(categoryData.parentCid, userLang);
if (req.originalUrl.startsWith(`${relative_path}/api/category`) || req.originalUrl.startsWith(`${relative_path}/category`)) {
categoryData.breadcrumbs = crumbs.concat(breadcrumbs);
}