Skip to content

Node.js based forum software built for the modern web

fix: logic in checkRequired

Barış Soner Uşaklı2428602f27ff
diff --git a/src/middleware/index.js b/src/middleware/index.js
index aa4c456c91..568e0c0aa6 100644
--- a/src/middleware/index.js
+++ b/src/middleware/index.js
@@ -308,14 +308,20 @@ middleware.validateAuth = helpers.try(async (req, res, next) => {
});
middleware.checkRequired = function (fields, req, res, next) {
+ const body = req.body || {};
+ const query = req.query || {};
// Used in API calls to ensure that necessary parameters/data values are present
const missing = fields.filter(
- field => req.body && !req.body.hasOwnProperty(field) && !req.query.hasOwnProperty(field)
+ field => !body.hasOwnProperty(field) && !query.hasOwnProperty(field)
);
if (!missing.length) {
return next();
}
- controllers.helpers.formatApiResponse(400, res, new Error(`[[error:required-parameters-missing, ${missing.join(' ')}]]`));
+ controllers.helpers.formatApiResponse(
+ 400,
+ res,
+ new Error(`[[error:required-parameters-missing, ${missing.join(' ')}]]`)
+ );
};