Node.js based forum software built for the modern web
fix: escape title in taskbar
Barış Soner Uşaklı268b0c84cec2
diff --git a/public/src/modules/taskbar.js b/public/src/modules/taskbar.jsindex 46aaa3c10f..ad6aca666a 100644--- a/public/src/modules/taskbar.js+++ b/public/src/modules/taskbar.js@@ -176,17 +176,17 @@ define('taskbar', ['translator', 'hooks', 'helpers'], function (translator, hookreturn callback();}translator.translate(data.options.title, function (taskTitle) {- const title = $('<div></div>').text(taskTitle || 'NodeBB Task').html();+ const title = helpers.escape(taskTitle || 'NodeBB Task');const image = data.options.image ? helpers.escape(data.options.image) : '';const icon = data.options.icon ? helpers.escape(data.options.icon) : '';- const taskbarEl = $('<li></li>')++ const taskbarEl = $(`<li title="${title}"></li>`).addClass(data.options.className).html('<a href="#"' + (image ? ` style="background-image: url('${image}'); background-size: cover;"` : '') + '>' +(icon ? `<i class="fa ${icon}"></i> ` : '') +`<span aria-label="${title}" component="taskbar/title">${title}</span>` +'</a>').attr({- title: title,'data-module': data.module,'data-uuid': data.uuid,})