Skip to content

Node.js based forum software built for the modern web

fix(activitypub): use raw body buffer for digest verification

Julian Lam2d0e90b8e83b
diff --git a/src/activitypub/index.js b/src/activitypub/index.js
index a4a520fefa..d4994f6298 100644
--- a/src/activitypub/index.js
+++ b/src/activitypub/index.js
@@ -343,7 +343,7 @@ ActivityPub.verify = async (req) => {
// Verify Digest header matches request body
if (headers.includes('digest')) {
const receivedDigest = req.headers.digest;
- const bodyData = typeof req.body === 'string' ? req.body : JSON.stringify(req.body);
+ const bodyData = req.rawBody || (typeof req.body === 'string' ? req.body : JSON.stringify(req.body));
const bodyDigest = `SHA-256=${createHash('sha256').update(bodyData).digest('base64')}`;
if (receivedDigest !== bodyDigest) {
ActivityPub.helpers.log('[activitypub/verify] Failed, digest mismatch.');
diff --git a/src/webserver.js b/src/webserver.js
index 2c6f1a35aa..7c60703107 100644
--- a/src/webserver.js
+++ b/src/webserver.js
@@ -275,6 +275,9 @@ function configureBodyParser(app) {
'application/activity+json',
],
limit: '1mb',
+ verify: (req, res, buf) => {
+ req.rawBody = buf;
+ },
...nconf.get('bodyParser:json'),
};
app.use(bodyParser.json(jsonOpts));