Node.js based forum software built for the modern web
fix: dont allow loading group list via api/v3
Barış Soner Uşaklı3760c1e44ffa
diff --git a/src/api/groups.js b/src/api/groups.jsindex 957d6483dc..0574ab3f47 100644--- a/src/api/groups.js+++ b/src/api/groups.js@@ -12,6 +12,10 @@ const tx = require('../translator');const groupsAPI = module.exports;groupsAPI.list = async (caller, data) => {+ const canView = await privileges.global.can('view:groups', caller.uid);+ if (!canView) {+ throw new Error('[[error:no-privileges]]');+ }const page = parseInt(data.page, 10) || 1;const groupsPerPage = 15;const start = Math.max(0, page - 1) * groupsPerPage;diff --git a/test/groups.js b/test/groups.jsindex 4f97b05868..02432cff8c 100644--- a/test/groups.js+++ b/test/groups.js@@ -1176,6 +1176,16 @@ describe('Groups', () => {const { users } = await apiGroups.listMembers({ uid: adminUid }, { after: 0, groupName: 'PrivateCanJoin' });assert(Array.isArray(users));});++ it('should not allow loading group list if user does not have view:groups privilege', async () => {+ const privileges = require('../src/privileges');+ await privileges.global.rescind(['groups:view:groups'], 'registered-users');+ await assert.rejects(+ apiGroups.list({ uid: testUid }, { after: 0, sort: 'name' }),+ { message: '[[error:no-privileges]]' }+ );+ await privileges.global.give(['groups:view:groups'], 'registered-users');+ });});describe('api methods', () => {