Skip to content

Node.js based forum software built for the modern web

perf: use a single filterUids

Barış Soner Uşaklı3b76bf792212
diff --git a/src/user/notifications.js b/src/user/notifications.js
index 2fab8c7555..4a4bb03b70 100644
--- a/src/user/notifications.js
+++ b/src/user/notifications.js
@@ -241,11 +241,14 @@ UserNotifications.sendTopicNotificationToFollowers = async function (uid, topicD
tagFollowers = _.uniq(tagFollowers).filter(_uid => !userFollowersSet.has(_uid) && _uid !== String(uid));
categoryFollowers = categoryFollowers.filter(_uid => !userFollowersSet.has(_uid) && _uid !== String(uid));
- [userFollowers, tagFollowers, categoryFollowers] = await Promise.all([
- privileges.categories.filterUids('topics:read', cid, userFollowers),
- privileges.categories.filterUids('topics:read', cid, tagFollowers),
- privileges.categories.filterUids('topics:read', cid, categoryFollowers),
- ]);
+ const uidsThatCanSeeTopic = new Set(
+ await privileges.categories.filterUids('topics:read', cid, [
+ ...userFollowers, ...tagFollowers, ...categoryFollowers,
+ ])
+ );
+ userFollowers = userFollowers.filter(_uid => uidsThatCanSeeTopic.has(_uid));
+ tagFollowers = tagFollowers.filter(_uid => uidsThatCanSeeTopic.has(_uid));
+ categoryFollowers = categoryFollowers.filter(_uid => uidsThatCanSeeTopic.has(_uid));
function createNotification(data) {
return notifications.create({