Skip to content

Node.js based forum software built for the modern web

chore: up lavender, widgets, fix translator test

Barış Soner Uşaklı3b9115b03ae1
diff --git a/install/package.json b/install/package.json
index 71465182d9..68a1aa88dc 100644
--- a/install/package.json
+++ b/install/package.json
@@ -101,16 +101,16 @@
"mousetrap": "1.6.5",
"multer": "2.2.0",
"nconf": "0.13.0",
- "nodebb-plugin-2factor": "8.0.2",
+ "nodebb-plugin-2factor": "8.0.3",
"nodebb-plugin-composer-default": "11.0.5",
"nodebb-plugin-dbsearch": "7.0.0",
- "nodebb-plugin-emoji": "6.0.14",
+ "nodebb-plugin-emoji": "6.0.15",
"nodebb-plugin-emoji-android": "4.1.1",
"nodebb-plugin-link-preview": "2.2.8",
- "nodebb-plugin-markdown": "13.2.6",
+ "nodebb-plugin-markdown": "13.2.7",
"nodebb-plugin-mentions": "5.0.0",
- "nodebb-plugin-spam-be-gone": "2.3.4",
- "nodebb-plugin-web-push": "0.8.2",
+ "nodebb-plugin-spam-be-gone": "2.3.5",
+ "nodebb-plugin-web-push": "0.9.0",
"nodebb-rewards-essentials": "1.0.3",
"nodebb-theme-harmony": "3.1.0",
"nodebb-theme-lavender": "8.1.0",
diff --git a/public/src/modules/helpers.common.js b/public/src/modules/helpers.common.js
index 87e59ff899..3c7fb2fb65 100644
--- a/public/src/modules/helpers.common.js
+++ b/public/src/modules/helpers.common.js
@@ -85,8 +85,7 @@ module.exports = function (utils, Benchpress, tx, relative_path) {
});
const translation = this._i18n[namespace][key];
- const result = tx.replaceArguments(translation, escapedArgs);
- return result;
+ return tx.replaceArguments(translation, escapedArgs);
}
function buildMetaTag(tag) {
diff --git a/test/topics/events.js b/test/topics/events.js
index 5fb12e7a24..36f989590c 100644
--- a/test/topics/events.js
+++ b/test/topics/events.js
@@ -105,7 +105,7 @@ describe('Topic Events', () => {
});
});
- it('should properly escape topic events with HTML and tx tokens in their arguments', async () => {
+ it('should properly escape topic events with HTML in their arguments', async () => {
const oldVlaueShowFullnameAsDisplayName = meta.config.showFullnameAsDisplayName;
meta.config.showFullnameAsDisplayName = 1;
const { topicData } = await topics.post({
@@ -127,7 +127,7 @@ describe('Topic Events', () => {
const events = await topics.events.get(topicData.tid, uid);
- assert.deepStrictEqual(events[0].text, `<span title="&quot;&gt;&lt;script&gt;alert(&quot;xss&quot;)&lt;/script&gt; &lsqb;&lsqb;global:posts&rsqb;&rsqb;" data-uid="${uid}" class="avatar avatar-rounded" component="avatar/icon" style="--avatar-size: 16px; background-color: #827717">B</span> <a href="${nconf.get('relative_path')}/user/bar">&quot;&gt;&lt;script&gt;alert(&quot;xss&quot;)&lt;/script&gt; &lsqb;&lsqb;global:posts&rsqb;&rsqb;</a> <a href="${nconf.get('relative_path')}/topic/${topicData.tid}">forked</a> this topic <span class="timeago timeline-text" title="${new Date(now).toISOString()}"></span>`);
+ assert.deepStrictEqual(events[0].text, `<span title="&quot;&gt;&lt;script&gt;alert(&quot;xss&quot;)&lt;/script&gt; [[global:posts]]" data-uid="${uid}" class="avatar avatar-rounded" component="avatar/icon" style="--avatar-size: 16px; background-color: #827717">B</span> <a href="${nconf.get('relative_path')}/user/bar">&quot;&gt;&lt;script&gt;alert(&quot;xss&quot;)&lt;/script&gt; [[global:posts]]</a> <a href="${nconf.get('relative_path')}/topic/${topicData.tid}">forked</a> this topic <span class="timeago timeline-text" title="${new Date(now).toISOString()}"></span>`);
meta.config.showFullnameAsDisplayName = oldVlaueShowFullnameAsDisplayName;
});