Skip to content

Node.js based forum software built for the modern web

fix(activitypub): #14275, delete topic when Announce(Delete) targets last post

Julian Lam412dd61b0970
diff --git a/src/activitypub/inbox.js b/src/activitypub/inbox.js
index 61a3dd16ea..289ff6a0bc 100644
--- a/src/activitypub/inbox.js
+++ b/src/activitypub/inbox.js
@@ -13,6 +13,7 @@ const notifications = require('../notifications');
const messaging = require('../messaging');
const flags = require('../flags');
const api = require('../api');
+const apiHelpers = require('../api/helpers');
const utils = require('../utils');
const activitypub = require('.');
@@ -465,7 +466,16 @@ inbox.announce = async (req) => {
}
const uid = await posts.getPostField(id, 'uid');
- await posts.delete(id, uid);
+ const isMain = await posts.isMain(id);
+ const postCount = await topics.getTopicField(await posts.getPostField(id, 'tid'), 'postcount');
+ const isLast = postCount === 1;
+
+ await posts.tools.delete(uid, id);
+
+ if (isMain && isLast) {
+ const tid = await posts.getPostField(id, 'tid');
+ await apiHelpers.doTopicAction('delete', 'event:topic_deleted', { uid }, { tids: [tid] });
+ }
break;
}
diff --git a/test/activitypub/inbox.js b/test/activitypub/inbox.js
index c855219653..dfed357981 100644
--- a/test/activitypub/inbox.js
+++ b/test/activitypub/inbox.js
@@ -496,6 +496,93 @@ describe('Inbox', () => {
const isDeleted = await posts.getPostField(id, 'deleted');
assert.strictEqual(isDeleted, 1);
});
+
+ it('should delete the topic if the post is the only post in the topic', async () => {
+ const uid = await user.create({ username: utils.generateUUID().slice(0, 10) });
+ const { id: cid } = helpers.mocks.group();
+ await activitypub.actors.assertGroup(cid);
+ const { postData, topicData } = await topics.post({
+ uid,
+ cid,
+ title: utils.generateUUID(),
+ content: utils.generateUUID(),
+ });
+
+ // Verify topic exists before deletion
+ const topicExistsBefore = await topics.exists(topicData.tid);
+ assert.strictEqual(topicExistsBefore, true);
+
+ // Create a delete activity for the local post
+ const object = await activitypub.mocks.notes.public(postData);
+ const { activity: deleteActivity } = helpers.mocks.delete({
+ actor: `${nconf.get('url')}/uid/${postData.uid}`,
+ object,
+ });
+
+ // Wrap it in an announce
+ const { activity } = helpers.mocks.announce({
+ actor: cid,
+ object: deleteActivity,
+ });
+
+ // Process the announce
+ await activitypub.inbox.announce({ body: activity });
+
+ // Verify post is deleted
+ const isDeleted = await posts.getPostField(postData.pid, 'deleted');
+ assert.strictEqual(isDeleted, 1);
+
+ // Verify topic is also deleted
+ const topicDeleted = await topics.getTopicField(topicData.tid, 'deleted');
+ assert.strictEqual(topicDeleted, 1);
+ });
+
+ it('should NOT delete the topic if there are replies', async () => {
+ const uid = await user.create({ username: utils.generateUUID().slice(0, 10) });
+ const { id: cid } = helpers.mocks.group();
+ await activitypub.actors.assertGroup(cid);
+ const { postData, topicData } = await topics.post({
+ uid,
+ cid,
+ title: utils.generateUUID(),
+ content: utils.generateUUID(),
+ });
+
+ // Add a reply to the topic
+ await topics.reply({
+ tid: topicData.tid,
+ uid,
+ content: utils.generateUUID(),
+ });
+
+ // Verify topic exists before deletion
+ const topicExistsBefore = await topics.exists(topicData.tid);
+ assert.strictEqual(topicExistsBefore, true);
+
+ // Create a delete activity for the local post (main post)
+ const object = await activitypub.mocks.notes.public(postData);
+ const { activity: deleteActivity } = helpers.mocks.delete({
+ actor: `${nconf.get('url')}/uid/${postData.uid}`,
+ object,
+ });
+
+ // Wrap it in an announce
+ const { activity } = helpers.mocks.announce({
+ actor: cid,
+ object: deleteActivity,
+ });
+
+ // Process the announce
+ await activitypub.inbox.announce({ body: activity });
+
+ // Verify post is deleted
+ const isDeleted = await posts.getPostField(postData.pid, 'deleted');
+ assert.strictEqual(isDeleted, 1);
+
+ // Verify topic still exists (not deleted because there are replies)
+ const topicExistsAfter = await topics.exists(topicData.tid);
+ assert.strictEqual(topicExistsAfter, true);
+ });
});
});