Node.js based forum software built for the modern web
feat: let plugins map admin routes to privileges from static:privileges.admin.init (#14891)
palmoni5527b86874aa9
diff --git a/src/privileges/admin.js b/src/privileges/admin.jsindex a9588cbf6d..ca6710085e 100644--- a/src/privileges/admin.js+++ b/src/privileges/admin.js@@ -31,6 +31,9 @@ const _privilegeMap = new Map([privsAdmin.init = async () => {await plugins.hooks.fire('static:privileges.admin.init', {privileges: _privilegeMap,+ routeMap: privsAdmin.routeMap,+ routePrefixMap: privsAdmin.routePrefixMap,+ socketMap: privsAdmin.socketMap,});for (const [, value] of _privilegeMap) {diff --git a/test/controllers-admin.js b/test/controllers-admin.jsindex 177f95ce74..2db0f8af7e 100644--- a/test/controllers-admin.js+++ b/test/controllers-admin.js@@ -758,6 +758,37 @@ describe('Admin Controllers', () => {});});+ describe('static:privileges.admin.init', () => {+ const plugins = require('../src/plugins');+ const route = 'plugins/delegated-plugin-page';+ const method = async (data) => {+ data.routeMap[route] = 'admin:users';+ return data;+ };++ before(async () => {+ plugins.hooks.register('admin-init-test', { hook: 'static:privileges.admin.init', method });+ await privileges.admin.init();+ });++ after(() => {+ plugins.hooks.unregister('admin-init-test', 'static:privileges.admin.init', method);+ delete privileges.admin.routeMap[route];+ });++ it('should let a plugin map its admin page to an admin privilege', async () => {+ await privileges.admin.rescind(['admin:users'], uid);+ let { response: res } = await request.get(`${nconf.get('url')}/api/admin/${route}`, requestOpts);+ assert.strictEqual(res.statusCode, 403);++ await privileges.admin.give(['admin:users'], uid);+ ({ response: res } = await request.get(`${nconf.get('url')}/api/admin/${route}`, requestOpts));+ assert.strictEqual(res.statusCode, 404);++ await privileges.admin.rescind(['admin:users'], uid);+ });+ });+it('should list all admin privileges', async () => {const privs = await privileges.admin.getPrivilegeList();assert.deepStrictEqual(privs, [