Skip to content

Node.js based forum software built for the modern web

test: fix email test

Barış Soner Uşaklı5d32e4278f60
diff --git a/src/api/users.js b/src/api/users.js
index 4702e11651..e8b3520645 100644
--- a/src/api/users.js
+++ b/src/api/users.js
@@ -490,10 +490,10 @@ usersAPI.getEmail = async (caller, { uid, email }) => {
const [isPrivileged, { showemail }, ownerUid] = await Promise.all([
user.isAdminOrGlobalMod(caller.uid),
user.getSettings(uid),
- db.sortedSetScore('email:uid', email.toLowerCase()),
+ db.sortedSetScore('email:uid', String(email).toLowerCase()),
]);
const isSelf = caller.uid === parseInt(uid, 10);
- const exists = ownerUid && parseInt(ownerUid, 10) === parseInt(uid, 10);
+ const exists = parseInt(ownerUid, 10) === parseInt(uid, 10);
return exists && (isSelf || isPrivileged || showemail);
};
diff --git a/test/user.js b/test/user.js
index 10c2daf70c..2c8105326f 100644
--- a/test/user.js
+++ b/test/user.js
@@ -2575,7 +2575,7 @@ describe('User', () => {
it('should respect admin setting in api.user.getEmail', async () => {
assert.strictEqual(
- await apiUser.getEmail({ uid: regularUser.uid }, { uid: hidingUser.uid }),
+ await apiUser.getEmail({ uid: regularUser.uid }, { uid: hidingUser.uid, email: hidingUser.email }),
false,
);
});