Skip to content

Node.js based forum software built for the modern web

fix: don't expose user existence if visitor can't view users (#12447)

Jakub Bliźniuk61a7a0aa58a5
diff --git a/src/middleware/index.js b/src/middleware/index.js
index 9b1cbad720..aad7469a2d 100644
--- a/src/middleware/index.js
+++ b/src/middleware/index.js
@@ -176,14 +176,14 @@ middleware.privateTagListing = helpers.try(async (req, res, next) => {
});
middleware.exposeGroupName = helpers.try(async (req, res, next) => {
- await expose('groupName', groups.getGroupNameByGroupSlug, 'slug', req, res, next);
+ await expose('groupName', groups.getGroupNameByGroupSlug, middleware.canViewGroups, 'slug', req, res, next);
});
middleware.exposeUid = helpers.try(async (req, res, next) => {
- await expose('uid', user.getUidByUserslug, 'userslug', req, res, next);
+ await expose('uid', user.getUidByUserslug, middleware.canViewUsers, 'userslug', req, res, next);
});
-async function expose(exposedField, method, field, req, res, next) {
+async function expose(exposedField, method, canViewMethod, field, req, res, next) {
if (!req.params.hasOwnProperty(field)) {
return next();
}
@@ -197,7 +197,7 @@ async function expose(exposedField, method, field, req, res, next) {
const value = await method(param);
if (!value) {
- next('route');
+ canViewMethod(req, res, () => next('route'));
return;
}