Node.js based forum software built for the modern web
Gate activitypub user actor routes with view:users privilege
Julian Lam6457ef3bc65b
diff --git a/src/controllers/activitypub/actors.js b/src/controllers/activitypub/actors.jsindex 6745d42290..b6f861cebb 100644--- a/src/controllers/activitypub/actors.js+++ b/src/controllers/activitypub/actors.js@@ -42,13 +42,14 @@ Actors.application = async function (req, res) {};Actors.user = async function (req, res) {- // todo: view:users priv gate+ // Privilege-gated at the router-levelconst payload = await activitypub.mocks.actors.user(req.params.uid);res.status(200).json(payload);};Actors.userBySlug = async function (req, res) {+ // Privilege-gated at the router-levelconst { uid } = res.locals;req.params.uid = uid;delete req.params.userslug;diff --git a/src/routes/activitypub.js b/src/routes/activitypub.jsindex 0f958b2e46..59c14654eb 100644--- a/src/routes/activitypub.js+++ b/src/routes/activitypub.js@@ -35,8 +35,8 @@ module.exports = function (app, middleware, controllers) {app.get('/actor', middlewares, helpers.tryRoute(controllers.activitypub.actors.application));app.post('/inbox', [...middlewares, ...inboxMiddlewares], helpers.tryRoute(controllers.activitypub.postInbox));- app.get('/uid/:uid', [...middlewares, middleware.assert.user], helpers.tryRoute(controllers.activitypub.actors.user));- app.get('/user/:userslug', [...middlewares, middleware.exposeUid, middleware.assert.user], helpers.tryRoute(controllers.activitypub.actors.userBySlug));+ app.get('/uid/:uid', [...middlewares, middleware.assert.user, middleware.canViewUsers], helpers.tryRoute(controllers.activitypub.actors.user));+ app.get('/user/:userslug', [...middlewares, middleware.exposeUid, middleware.assert.user, middleware.canViewUsers], helpers.tryRoute(controllers.activitypub.actors.userBySlug));app.get('/uid/:uid/inbox', [...middlewares, middleware.assert.user], helpers.tryRoute(controllers.activitypub.getInbox));app.post('/uid/:uid/inbox', [...middlewares, middleware.assert.user, ...inboxMiddlewares], helpers.tryRoute(controllers.activitypub.postInbox));app.get('/uid/:uid/outbox', [...middlewares, middleware.assert.user], helpers.tryRoute(controllers.activitypub.getOutbox));