Node.js based forum software built for the modern web
fix: ensure check returns false if no addresses are looked up, fix bug where cached value got changed accidentally
Julian Lam6478532bf5e8
diff --git a/src/request.js b/src/request.jsindex fe8de851c1..ce5e95d5bb 100644--- a/src/request.js+++ b/src/request.js@@ -45,7 +45,8 @@ async function init() {* - For whatever reason `undici` needs to be required so that lookup can be overwritten properly.*/function lookup(hostname, options, callback) {- const { ok, lookup } = checkCache.get(hostname);+ let { ok, lookup } = checkCache.get(hostname);+ lookup = [...lookup];if (!ok) {throw new Error('lookup-failed');}@@ -166,6 +167,10 @@ async function check(url) {});}+ if (addresses.size < 1) {+ return { ok: false };+ }+// Every IP address that the host resolves to should be a unicast addressconst ok = Array.from(addresses).every(({ address: ip }) => {const parsed = ipaddr.parse(ip);