Node.js based forum software built for the modern web
fix: guard against crash when malformed URL present in deliverees
Julian Lam6a0663cdd0a6
diff --git a/src/activitypub/index.js b/src/activitypub/index.jsindex 85491b27b1..c5b5417020 100644--- a/src/activitypub/index.js+++ b/src/activitypub/index.js@@ -135,11 +135,17 @@ ActivityPub.resolveInboxes = async (ids) => {// Filter out blocked instancesconst blocked = [];inboxArr = inboxArr.filter((inbox) => {- const { hostname } = new URL(inbox);- const allowed = ActivityPub.instances.isAllowed(hostname);- if (!allowed) {- blocked.push(inbox);+ let allowed = false;+ try {+ const { hostname } = new URL(inbox);+ allowed = ActivityPub.instances.isAllowed(hostname);+ if (!allowed) {+ blocked.push(inbox);+ }+ } catch (e) {+ winston.warn(`[activitypub/resolveInboxes] Malformed URL encountered while filtering out blocked instances: ${inbox}`);}+return allowed;});if (blocked.length) {