Node.js based forum software built for the modern web
fix: closes #14560, check every pid belongs to fromTid
Barış Soner Uşaklı799178687c81
diff --git a/src/topics/fork.js b/src/topics/fork.jsindex 22903d112e..6239136ffe 100644--- a/src/topics/fork.js+++ b/src/topics/fork.js@@ -25,15 +25,11 @@ module.exports = function (Topics) {if (!pids || !pids.length) {throw new Error('[[error:invalid-pid]]');}-- if (pids.every(isFinite)) {- pids.sort((a, b) => a - b);- } else {- const pidsDatetime = (await db.sortedSetScores(`tid:${fromTid}:posts`, pids)).map(t => t || 0);- const map = pids.reduce((map, pid, idx) => map.set(pidsDatetime[idx], pid), new Map());- pidsDatetime.sort((a, b) => a - b);- pids = pidsDatetime.map(key => map.get(key));+ const sourcePosts = await posts.getPostsFields(pids, ['pid', 'tid', 'timestamp']);+ if (sourcePosts.some(p => !p?.tid || String(p.tid) !== String(fromTid))) {+ throw new Error('[[error:invalid-pid]]');}+ pids = sourcePosts.sort((a, b) => a.timestamp - b.timestamp).map(p => p.pid);const mainPid = pids[0];if (!cid) {@@ -65,15 +61,17 @@ module.exports = function (Topics) {tid: mainPost.tid,});+ const canEditAll = await Promise.all(pids.map(pid => privileges.posts.canEdit(pid, uid)));+ const failed = canEditAll.find(canEdit => !canEdit.flag);+ if (failed) {+ throw new Error(failed.message);+ }+const tid = await Topics.create(result.params);await Topics.updateTopicBookmarks(fromTid, pids);for (const pid of pids) {/* eslint-disable no-await-in-loop */- const canEdit = await privileges.posts.canEdit(pid, uid);- if (!canEdit.flag) {- throw new Error(canEdit.message);- }await Topics.movePostToTopic(uid, pid, tid, scheduled);}