Skip to content

Node.js based forum software built for the modern web

fix: check topics:read privilege when loading post diffs

Barış Soner Uşaklı8467945977fc
diff --git a/src/api/posts.js b/src/api/posts.js
index 492229c575..a9affbe2bd 100644
--- a/src/api/posts.js
+++ b/src/api/posts.js
@@ -482,12 +482,14 @@ postsAPI.unbookmark = async function (caller, data) {
};
async function diffsPrivilegeCheck(pid, uid) {
- const [deleted, privilegesData] = await Promise.all([
+ const [deleted, [privilegesData]] = await Promise.all([
posts.getPostField(pid, 'deleted'),
privileges.posts.get([pid], uid),
]);
- const allowed = privilegesData[0]['posts:history'] && (deleted ? privilegesData[0]['posts:view_deleted'] : true);
+ const allowed = privilegesData['posts:history'] &&
+ privilegesData['topics:read'] &&
+ (!deleted || privilegesData['posts:view_deleted']);
if (!allowed) {
throw new Error('[[error:no-privileges]]');
}
diff --git a/test/posts.js b/test/posts.js
index 555c25f0ef..6476041712 100644
--- a/test/posts.js
+++ b/test/posts.js
@@ -572,6 +572,16 @@ describe('Post\'s', () => {
assert.strictEqual(err.message, '[[error:no-privileges]]');
});
+ it('should not allow registered-users group to view diffs if they do not have the topics:read privilege', async () => {
+ await privileges.categories.rescind(['groups:topics:read'], cid, 'registered-users');
+ await assert.rejects(
+ apiPosts.getDiffs({ uid: voterUid }, { pid: 1 }),
+ { message: '[[error:no-privileges]]' }
+ );
+
+ await privileges.categories.give(['groups:topics:read'], cid, 'registered-users');
+ });
+
it('should allow registered-users group to view diffs', async () => {
const data = await apiPosts.getDiffs({ uid: 1 }, { pid: 1 });