Skip to content

Node.js based forum software built for the modern web

fix(activitypub): limit activity dedup window to 10s

Julian Lam8f7471c30add
diff --git a/src/middleware/activitypub.js b/src/middleware/activitypub.js
index 1bc9b411f4..43da64ca05 100644
--- a/src/middleware/activitypub.js
+++ b/src/middleware/activitypub.js
@@ -94,9 +94,9 @@ middleware.assertPayload = helpers.try(async function (req, res, next) {
}
activitypub.helpers.log('[middleware/activitypub] Request body check passed.');
- // History check
- const seen = await db.isSortedSetMember('activities:datetime', req.body.id);
- if (seen) {
+ // History check (w/in last 10 seconds)
+ const seenTimestamp = await db.sortedSetScore('activities:datetime', req.body.id);
+ if (seenTimestamp && (Date.now() - seenTimestamp) < 10000) {
activitypub.helpers.log(`[middleware/activitypub] Activity already seen, ignoring (${req.body.id}).`);
return res.sendStatus(200);
}