Skip to content

Node.js based forum software built for the modern web

fix: deep clone activity prop before execution; feps.announce

Julian Lam977a67f4cd84
diff --git a/src/activitypub/feps.js b/src/activitypub/feps.js
index 262010b7da..9d1f006905 100644
--- a/src/activitypub/feps.js
+++ b/src/activitypub/feps.js
@@ -10,6 +10,8 @@ const activitypub = module.parent.exports;
const Feps = module.exports;
Feps.announce = async function announce(id, activity) {
+ activity = structuredClone(activity);
+
let localId;
if (String(id).startsWith(nconf.get('url'))) {
({ id: localId } = await activitypub.helpers.resolveLocalId(id));
diff --git a/test/activitypub/feps.js b/test/activitypub/feps.js
index a33ebd597c..3e4b10f0b4 100644
--- a/test/activitypub/feps.js
+++ b/test/activitypub/feps.js
@@ -163,10 +163,8 @@ describe('FEPs', () => {
cc: [`${nconf.get('url')}/category/${cid}`],
});
pid = id;
- console.log('note passed to mocks.create', note);
({ activity } = await helpers.mocks.create(note));
- console.log('activity passed to inbox.create', activity);
await activitypub.inbox.create({ body: activity });
const activities = Array.from(activitypub._sent);
@@ -183,7 +181,6 @@ describe('FEPs', () => {
return activity.type === 'Announce' &&
activity.object && activity.object.type === 'Note';
});
- console.log('activities', JSON.stringify(activities, null, 2));
assert(test1 && test2);
});