Skip to content

Node.js based forum software built for the modern web

fix: only allow sort by flags for privileged users

Barış Soner Uşaklı9af2e8b80d06
diff --git a/src/api/users.js b/src/api/users.js
index e8b3520645..abd0fca534 100644
--- a/src/api/users.js
+++ b/src/api/users.js
@@ -623,7 +623,8 @@ usersAPI.search = async function (caller, data) {
searchBy === 'email' ||
filters.includes('banned') ||
filters.includes('muted') ||
- filters.includes('flagged')
+ filters.includes('flagged') ||
+ data.sortBy === 'flags'
) && !isPrivileged)
) {
throw new Error('[[error:no-privileges]]');
diff --git a/src/user/search.js b/src/user/search.js
index 22f4b32b87..b5d502361f 100644
--- a/src/user/search.js
+++ b/src/user/search.js
@@ -11,7 +11,7 @@ const activitypub = require('../activitypub');
const utils = require('../utils');
module.exports = function (User) {
- const validSorts = new Set(['joindate', 'lastonline', 'postcount', 'reputation']);
+ const validSorts = new Set(['joindate', 'lastonline', 'postcount', 'reputation', 'flags']);
const filterFnMap = {
online: user => user.status !== 'offline' && (Date.now() - user.lastonline < 300000),