Skip to content

Node.js based forum software built for the modern web

fix: add escaping to id/type/activityType in AP/errors ACP page to guard against improper user data

Julian Lama0ffa2ec9337
diff --git a/src/controllers/admin/federation.js b/src/controllers/admin/federation.js
index 230e8b1fd9..c3ad734f4a 100644
--- a/src/controllers/admin/federation.js
+++ b/src/controllers/admin/federation.js
@@ -130,7 +130,16 @@ federationController.errors = async function (req, res) {
// noop
}
- return { id, type, activityType, body, stack, hostname, timestamp, timestampISO };
+ return {
+ id: validator.escape(String(id)),
+ type: validator.escape(String(type)),
+ activityType: validator.escape(String(activityType)),
+ body,
+ stack,
+ hostname,
+ timestamp,
+ timestampISO,
+ };
}).filter(Boolean);
res.render('admin/federation/errors', {