Node.js based forum software built for the modern web
fix: uids used for priv check
Barış Soner Uşaklıbd7bf5bee51b
diff --git a/src/controllers/accounts/consent.js b/src/controllers/accounts/consent.jsindex ef97f7f33f..9d16f72d74 100644--- a/src/controllers/accounts/consent.js+++ b/src/controllers/accounts/consent.js@@ -15,7 +15,7 @@ consentController.get = async function (req, res, next) {const { username, userslug } = payload;const [consented, canExport] = await Promise.all([db.getObjectField(`user:${res.locals.uid}`, 'gdpr_consent'),- privileges.users.canExportData(res.uid, res.locals.uid),+ privileges.users.canExportData(req.uid, res.locals.uid),]);payload.gdpr_consent = parseInt(consented, 10) === 1;diff --git a/src/controllers/write/users.js b/src/controllers/write/users.jsindex 839c3105ad..c0d9e54d56 100644--- a/src/controllers/write/users.js+++ b/src/controllers/write/users.js@@ -206,6 +206,7 @@ Users.confirmEmail = async (req, res) => {};Users.checkExportByType = async (req, res) => {+ console.log('CHECK FAIL?', req.uid, req.params.uid, req.params.type);const stat = await api.users.checkExportByType(req, { ...req.params });const modified = new Date(stat.mtimeMs);res.set('Last-Modified', modified.toUTCString());diff --git a/src/privileges/users.js b/src/privileges/users.jsindex 57b5a3cd0d..48ccbe3a6b 100644--- a/src/privileges/users.js+++ b/src/privileges/users.js@@ -149,8 +149,8 @@ privsUsers.canExportData = async function (callerUid, uid) {}const privsAdmin = require('./admin');const [isAdmin, hadAdminUsersPrivilege] = await Promise.all([- privsUsers.isAdministrator(uid),- privsAdmin.can('admin:users', uid),+ privsUsers.isAdministrator(callerUid),+ privsAdmin.can('admin:users', callerUid),]);return isAdmin || hadAdminUsersPrivilege;};