Skip to content

Node.js based forum software built for the modern web

fix: closes #15052, allow socket.emits from exempt groups

Barış Soner Uşaklıbe7580a75494
diff --git a/src/socket.io/index.js b/src/socket.io/index.js
index 310a2f289e..591160ad50 100644
--- a/src/socket.io/index.js
+++ b/src/socket.io/index.js
@@ -8,6 +8,7 @@ const cookieParser = require('cookie-parser')(nconf.get('secret'));
const db = require('../database');
const user = require('../user');
+const groups = require('../groups');
const logger = require('../logger');
const plugins = require('../plugins');
const ratelimit = require('../middleware/ratelimit');
@@ -235,8 +236,11 @@ async function checkMaintenance(socket) {
if (!meta.config.maintenanceMode) {
return;
}
- const isAdmin = await user.isAdministrator(socket.uid);
- if (isAdmin) {
+ const [isAdmin, isMemberOfExempt] = await Promise.all([
+ user.isAdministrator(socket.uid),
+ groups.isMemberOfAny(socket.uid, meta.config.groupsExemptFromMaintenanceMode),
+ ]);
+ if (isAdmin || isMemberOfExempt) {
return;
}
throw new Error(`[[pages:maintenance.text, ${meta.config.title || 'NodeBB'}]]`);