Node.js based forum software built for the modern web
refactor: use a Map
Barış Soner Uşaklıc29980d3e0a8
diff --git a/public/src/modules/helpers.common.js b/public/src/modules/helpers.common.jsindex 719e0e3b0f..968245ba59 100644--- a/public/src/modules/helpers.common.js+++ b/public/src/modules/helpers.common.js@@ -143,22 +143,22 @@ module.exports = function (utils, Benchpress, tx, relative_path) {.replace(/"/g, '"');}+ const routePrivilegeMap = new Map([+ ['/users', 'view:users'],+ ['/tags', 'view:tags'],+ ['/groups', 'view:groups'],+ ]);function displayMenuItem(data, index) {const item = data.navigation[index];if (!item) {return false;}-- if (item.route.match('/users') && data.user && !data.user.privileges['view:users']) {- return false;- }-- if (item.route.match('/tags') && data.user && !data.user.privileges['view:tags']) {- return false;- }-- if (item.route.match('/groups') && data.user && !data.user.privileges['view:groups']) {- return false;+ if (data.user) {+ for (const [route, privilege] of routePrivilegeMap) {+ if (item.route.startsWith(route) && !data.user.privileges[privilege]) {+ return false;+ }+ }}return true;