Skip to content

Node.js based forum software built for the modern web

fix(uploads): handle application/octet-stream as reported by browsers

Julian Lamc383e8b3ef68
diff --git a/src/controllers/uploads.js b/src/controllers/uploads.js
index d330b0c2ea..0975998c24 100644
--- a/src/controllers/uploads.js
+++ b/src/controllers/uploads.js
@@ -227,7 +227,10 @@ function normalizeMimeType(mimeType) {
async function validateUploadedFileMime(uploadedFile) {
const detected = await fileTypeFromFile(uploadedFile.path);
const detectedMimeType = detected ? detected.mime : mime.getType(uploadedFile.name);
- if (detectedMimeType && uploadedFile.type &&
+ if (
+ detectedMimeType &&
+ uploadedFile.type &&
+ uploadedFile.type !== 'application/octet-stream' &&
normalizeMimeType(detectedMimeType) !== normalizeMimeType(uploadedFile.type)
) {
throw new Error('[[error:invalid-mime-type]]');