Skip to content

Node.js based forum software built for the modern web

fix: update Like/Dislike to have addressees in activity

Julian Lamc8e349ca6626
diff --git a/src/activitypub/mocks.js b/src/activitypub/mocks.js
index 5eb0ed10d1..030175fb36 100644
--- a/src/activitypub/mocks.js
+++ b/src/activitypub/mocks.js
@@ -986,19 +986,31 @@ Mocks.activities.create = async (pid, uid, post) => {
return { activity, targets };
};
-Mocks.activities.like = (pid, uid) => ({
- id: `${nconf.get('url')}/uid/${uid}#activity/like/${encodeURIComponent(pid)}`,
- type: 'Like',
- actor: `${nconf.get('url')}/uid/${uid}`,
- object: utils.isNumber(pid) ? `${nconf.get('url')}/post/${pid}` : pid,
-});
+Mocks.activities.like = async (pid, uid) => {
+ const authorUid = await posts.getPostField(pid, 'uid');
-Mocks.activities.dislike = (pid, uid) => ({
- id: `${nconf.get('url')}/uid/${uid}#activity/dislike/${encodeURIComponent(pid)}`,
- type: 'Dislike',
- actor: `${nconf.get('url')}/uid/${uid}`,
- object: utils.isNumber(pid) ? `${nconf.get('url')}/post/${pid}` : pid,
-});
+ return {
+ id: `${nconf.get('url')}/uid/${uid}#activity/like/${encodeURIComponent(pid)}`,
+ type: 'Like',
+ actor: `${nconf.get('url')}/uid/${uid}`,
+ to: [activitypub._constants.publicAddress],
+ cc: [authorUid],
+ object: utils.isNumber(pid) ? `${nconf.get('url')}/post/${pid}` : pid,
+ };
+};
+
+Mocks.activities.dislike = async (pid, uid) => {
+ const authorUid = await posts.getPostField(pid, 'uid');
+
+ return {
+ id: `${nconf.get('url')}/uid/${uid}#activity/dislike/${encodeURIComponent(pid)}`,
+ type: 'Dislike',
+ actor: `${nconf.get('url')}/uid/${uid}`,
+ to: [activitypub._constants.publicAddress],
+ cc: [authorUid],
+ object: utils.isNumber(pid) ? `${nconf.get('url')}/post/${pid}` : pid,
+ };
+};
Mocks.activities.announce = async (tid, uid) => {
const { mainPid: pid, cid } = await topics.getTopicFields(tid, ['mainPid', 'cid']);
diff --git a/src/activitypub/out.js b/src/activitypub/out.js
index d0f075bdb5..45d902fb05 100644
--- a/src/activitypub/out.js
+++ b/src/activitypub/out.js
@@ -254,7 +254,7 @@ Out.delete.note = enabledCheck(async (uid, pid) => {
Out.like = {};
Out.like.note = enabledCheck(async (uid, pid) => {
- const payload = activitypub.mocks.activities.like(pid, uid);
+ const payload = await activitypub.mocks.activities.like(pid, uid);
if (!activitypub.helpers.isUri(pid)) { // only 1b12 announce for local likes
await activitypub.feps.announce(pid, payload);