Skip to content

Node.js based forum software built for the modern web

fix: update note assertion topic members check to simpler posts.exists check

Julian Lamd0c058263f5f
diff --git a/src/activitypub/notes.js b/src/activitypub/notes.js
index 832b8d152d..e1fc16c175 100644
--- a/src/activitypub/notes.js
+++ b/src/activitypub/notes.js
@@ -117,9 +117,8 @@ Notes.assert = async (uid, input, options = { skipChecks: false }) => {
await topics.tools.move(tid, { cid: options.cid, uid: 'system' });
}
- const members = await db.isSortedSetMembers(`tid:${tid}:posts`, chain.slice(1).map(p => p.pid));
- members.unshift(await posts.exists(mainPid));
- if (tid && members.every(Boolean)) {
+ const exists = await posts.exists(chain.map(p => p.pid));
+ if (tid && exists.every(Boolean)) {
// All cached, return early.
activitypub.helpers.log('[notes/assert] No new notes to process.');
await unlock(id);
@@ -212,7 +211,7 @@ Notes.assert = async (uid, input, options = { skipChecks: false }) => {
}
return post;
- }).filter((p, idx) => !members[idx]);
+ }).filter((p, idx) => !exists[idx]);
const count = unprocessed.length;
activitypub.helpers.log(`[notes/assert] ${count} new note(s) found.`);