Skip to content

Node.js based forum software built for the modern web

fix(security): apply CSRF protection to the v3 JSON login route

Julian Lamd48df6d7555f
diff --git a/src/routes/write/utilities.js b/src/routes/write/utilities.js
index 7f442bbfa2..805b34122b 100644
--- a/src/routes/write/utilities.js
+++ b/src/routes/write/utilities.js
@@ -10,7 +10,21 @@ const { setupApiRoute } = routeHelpers;
module.exports = function () {
// The "ping" routes are mounted at root level, but for organizational purposes, the controllers are in `utilities.js`
- setupApiRoute(router, 'post', '/login', [middleware.checkRequired.bind(null, ['username', 'password'])], controllers.write.utilities.login);
+ // This route skips authenticateRequest (see the skip list in middleware.user),
+ // so req.uid is never set and the CSRF gate (which checks req.uid >= 0) is
+ // bypassed. Set req.uid from the session so CSRF protection applies, preventing
+ // cross-site login and anonymous account lockout.
+ setupApiRoute(router, 'post', '/login', [
+ (req, res, next) => {
+ if (req.uid === undefined) {
+ req.uid = req.user ? parseInt(req.user.uid, 10) : 0;
+ req.loggedIn = !!req.user;
+ }
+ next();
+ },
+ middleware.applyCSRF,
+ middleware.checkRequired.bind(null, ['username', 'password']),
+ ], controllers.write.utilities.login);
return router;
};