Node.js based forum software built for the modern web
fix(socket.io): restrict moderation note editing to admins and original authors
Julian Lamd92eb01dfea4
diff --git a/src/socket.io/user.js b/src/socket.io/user.jsindex 7903d44014..049b50f7ab 100644--- a/src/socket.io/user.js+++ b/src/socket.io/user.js@@ -158,17 +158,21 @@ SocketUser.editModerationNote = async function (socket, data) {if (!socket.uid || !data || !data.uid || !data.note || !data.id) {throw new Error('[[error:invalid-data]]');}+ const notes = await user.getModerationNotesByIds(data.uid, [data.id]);+ const existingNote = notes.find(n => n && n.id === data.id);+ if (!existingNote) {+ throw new Error('[[error:no-privileges]]');+ }+ const isAuthor = socket.uid === existingNote.uid;+ const isAdmin = await user.isAdministrator(socket.uid);+ if (!isAdmin && !isAuthor) {+ throw new Error('[[error:no-privileges]]');+ }const noteData = {+ uid: existingNote.uid,note: data.note,timestamp: data.id,};- let canEdit = await privileges.users.canEdit(socket.uid, data.uid);- if (!canEdit) {- canEdit = await user.isModeratorOfAnyCategory(socket.uid);- }- if (!canEdit) {- throw new Error('[[error:no-privileges]]');- }await user.setModerationNote({ uid: data.uid, noteData });return await user.getModerationNotesByIds(data.uid, [data.id]);