Skip to content

Node.js based forum software built for the modern web

fix: missing middlewares on category inbox, gate email lookup behind user session

Julian Lamf9a51b2b0115
diff --git a/src/routes/activitypub.js b/src/routes/activitypub.js
index bb1fef1e93..bf875b9bfa 100644
--- a/src/routes/activitypub.js
+++ b/src/routes/activitypub.js
@@ -51,7 +51,7 @@ module.exports = function (app, middleware, controllers) {
app.get('/topic/:tid/:slug?', [...middlewares, middleware.assert.topic], helpers.tryRoute(controllers.activitypub.actors.topic));
app.get('/category/:cid/inbox', [...middlewares, middleware.assert.category], helpers.tryRoute(controllers.activitypub.getInbox));
- app.post('/category/:cid/inbox', [...inboxMiddlewares, middleware.assert.category, ...inboxMiddlewares], helpers.tryRoute(controllers.activitypub.postInbox));
+ app.post('/category/:cid/inbox', [...middlewares, middleware.assert.category, ...inboxMiddlewares], helpers.tryRoute(controllers.activitypub.postInbox));
app.get('/category/:cid/outbox', [...middlewares, middleware.assert.category], helpers.tryRoute(controllers.activitypub.getCategoryOutbox));
app.get('/category/:cid/moderators', [...middlewares, middleware.assert.category], helpers.tryRoute(controllers.activitypub.getCategoryModerators));
app.post('/category/:cid/outbox', [...middlewares, middleware.assert.category], helpers.tryRoute(controllers.activitypub.postOutbox));
diff --git a/src/user/interstitials.js b/src/user/interstitials.js
index 1558899497..10ebee2be1 100644
--- a/src/user/interstitials.js
+++ b/src/user/interstitials.js
@@ -34,7 +34,7 @@ Interstitials.email = async (data) => {
]);
let email;
- if (data.userData.uid) {
+ if (data.req.uid && data.userData.uid && data.req.uid === data.userData.uid) {
email = await user.getUserField(data.userData.uid, 'email');
} else if (data.userData.token) {
email = await user.getEmailFromToken(data.userData.token);