Node.js based forum software built for the modern web
fix: dont leak ip in api/v3 replies and summary
Barış Soner Uşaklıfadb4e34c588
diff --git a/src/posts/index.js b/src/posts/index.jsindex 53c3c4c334..4c8a3873ac 100644--- a/src/posts/index.js+++ b/src/posts/index.js@@ -96,12 +96,15 @@ Posts.getPostIndices = async function (posts, uid) {};Posts.modifyPostByPrivilege = function (post, privileges) {- if (post && post.deleted && !(post.selfPost || privileges['posts:view_deleted'])) {- post.content = '[[topic:post-is-deleted]]';- post.txContent = true;- if (post.user) {- post.user.signature = '';+ if (post && privileges) {+ if (post.deleted && !(post.selfPost || privileges['posts:view_deleted'])) {+ post.content = '[[topic:post-is-deleted]]';+ post.txContent = true;+ if (post.user) {+ post.user.signature = '';+ }}+ post.ip = privileges.isAdminOrMod ? post.ip : undefined;}};diff --git a/src/topics/posts.js b/src/topics/posts.jsindex 512b7f63d7..bde36cf1cc 100644--- a/src/topics/posts.js+++ b/src/topics/posts.js@@ -171,7 +171,6 @@ module.exports = function (Topics) {(post.selfPost && !topicData.locked && !post.deleted) ||(post.selfPost && post.deleted && parseInt(post.deleterUid, 10) === parseInt(topicPrivileges.uid, 10)) ||((loggedIn || topicData.postSharing.length) && !post.deleted);- post.ip = topicPrivileges.isAdminOrMod ? post.ip : undefined;posts.modifyPostByPrivilege(post, topicPrivileges);}