Skip to content

Never stop coding. Free MIT AI gateway: one endpoint, 375 providers (150+ free), 1,400+ models Kimi, Claude, GPT, Gemini, GLM, DeepSeek, MiniMax. Works with Claude Code, Codex, Cursor, OpenCode, Cline & Copilot. Quota-aware auto-fallback, RTK+Caveman compression saves 15-95% tokens, MCP/A2A, Desktop/PWA. Built by 900+ contributors

fix: remove implicit API key request caps (#2289)

diegosouzapwbaefcd06f097
diff --git a/src/shared/utils/apiKeyPolicy.ts b/src/shared/utils/apiKeyPolicy.ts
index 81000b9695..060def0bb6 100644
--- a/src/shared/utils/apiKeyPolicy.ts
+++ b/src/shared/utils/apiKeyPolicy.ts
@@ -8,7 +8,6 @@
* @module shared/utils/apiKeyPolicy
*/
-import { z } from "zod";
import { extractApiKey } from "@/sse/services/auth";
import { getApiKeyMetadata, isModelAllowedForKey } from "@/lib/localDb";
import { checkBudget } from "@/domain/costRules";
@@ -17,68 +16,10 @@ import { HTTP_STATUS } from "@omniroute/open-sse/config/constants.ts";
import * as log from "@/sse/utils/logger";
import { checkRateLimit, RateLimitRule } from "./rateLimiter";
-/**
- * Legacy default applied to API keys whose `rate_limits` column is null.
- * Kept as the secure-by-default fallback when DEFAULT_RATE_LIMIT_PER_DAY is
- * unset or malformed — going unlimited silently on an upgrade would expose
- * existing deployments to runaway cost / abuse from old, unconfigured keys.
- */
-const LEGACY_DEFAULT_PER_DAY = 1000;
-
-/**
- * Per Repository Style Guide rule 8, env input is validated through Zod
- * rather than `parseInt`. `parseInt("1000 requests", 10)` returns `1000`,
- * silently turning a config typo into a partial value — Zod rejects it.
- */
-const DEFAULT_RATE_LIMIT_PER_DAY_SCHEMA = z.coerce.number().int().min(0);
-
-/**
- * Build the fallback rate-limit rules applied to API keys whose
- * `rate_limits` column is null. Configurable via DEFAULT_RATE_LIMIT_PER_DAY:
- *
- * - unset / empty / malformed → 1000/day, 5000/week, 20000/month
- * (the legacy default; preserves existing behavior on upgrade).
- * - `0` (explicit opt-out) → empty rule set; `checkRateLimit()` short-
- * circuits empty input as allowed, so keys without an explicit limit
- * become effectively unlimited.
- * - any positive integer N → N/day, 5N/week, 20N/month.
- *
- * Exported for unit testing; production code should reference the
- * `DEFAULT_RATE_LIMITS` constant below.
- */
-export function buildDefaultRateLimits(
- envValue = process.env.DEFAULT_RATE_LIMIT_PER_DAY
-): RateLimitRule[] {
- const trimmed = (envValue ?? "").trim();
- let perDay: number;
- if (trimmed === "") {
- perDay = LEGACY_DEFAULT_PER_DAY;
- } else {
- const parsed = DEFAULT_RATE_LIMIT_PER_DAY_SCHEMA.safeParse(trimmed);
- if (!parsed.success) {
- // Malformed value — fall back to the legacy default rather than
- // silently going unlimited from a typo. The runtime cost of the
- // warning is paid once at module load.
- log.warn(
- "API_POLICY",
- `Invalid DEFAULT_RATE_LIMIT_PER_DAY=${JSON.stringify(envValue)}; ` +
- `falling back to ${LEGACY_DEFAULT_PER_DAY}/day. ` +
- `Set to "0" to explicitly disable the fallback.`
- );
- perDay = LEGACY_DEFAULT_PER_DAY;
- } else {
- perDay = parsed.data;
- }
- }
- if (perDay === 0) return [];
- return [
- { limit: perDay, window: 86400 },
- { limit: perDay * 5, window: 604800 },
- { limit: perDay * 20, window: 2592000 },
- ];
-}
-
-const DEFAULT_RATE_LIMITS: RateLimitRule[] = buildDefaultRateLimits();
+// Default to no per-key request cap. API keys can still opt into explicit
+// limits via Settings/API Manager, while provider/account quota controls remain
+// responsible for upstream 429 handling and fallback.
+const DEFAULT_RATE_LIMITS: RateLimitRule[] = [];
interface AccessSchedule {
enabled: boolean;
diff --git a/tests/unit/api-key-policy.test.ts b/tests/unit/api-key-policy.test.ts
index a812e3713b..d1df806fd6 100644
--- a/tests/unit/api-key-policy.test.ts
+++ b/tests/unit/api-key-policy.test.ts
@@ -461,6 +461,19 @@ test("enforceApiKeyPolicy rejects disallowed models and exhausted budgets", asyn
assert.match(await readErrorMessage(overBudget.rejection), /Daily budget exceeded/);
});
+test("enforceApiKeyPolicy does not rate-limit unrestricted keys by default", async () => {
+ const unrestrictedKey = await createKeyWithPolicy({ allowedModels: ["openai/*"] });
+ const policy = await loadPolicy("default-no-request-limit");
+
+ for (let i = 0; i < 1005; i += 1) {
+ const result = await policy.enforceApiKeyPolicy(
+ makePolicyRequest(unrestrictedKey.key),
+ "openai/gpt-4.1"
+ );
+ assert.equal(result.rejection, null);
+ }
+});
+
test("enforceApiKeyPolicy enforces request-per-minute limits and returns success when allowed", async () => {
const limitedKey = await createKeyWithPolicy({
allowedModels: ["openai/*"],