Never stop coding. Free MIT AI gateway: one endpoint, 375 providers (150+ free), 1,400+ models Kimi, Claude, GPT, Gemini, GLM, DeepSeek, MiniMax. Works with Claude Code, Codex, Cursor, OpenCode, Cline & Copilot. Quota-aware auto-fallback, RTK+Caveman compression saves 15-95% tokens, MCP/A2A, Desktop/PWA. Built by 900+ contributors
TypeScript a2aai-agentsai-gatewayanthropicclaudeclaude-codeclinecodexcopilotcursordeepseekfree-aigeminikimillm-gatewaymcpopenaiopenai-proxyqwentoken-saver
fix(encryption): return null on decryption failure to prevent sending encrypted tokens to providers (#1462)
Paijoceca26ae8780
diff --git a/src/lib/db/encryption.ts b/src/lib/db/encryption.tsindex bff219c1ef..b491a09a47 100644--- a/src/lib/db/encryption.ts+++ b/src/lib/db/encryption.ts@@ -110,14 +110,16 @@ export function decrypt(ciphertext: string | null | undefined): string | null |console.warn("[Encryption] Found encrypted data but STORAGE_ENCRYPTION_KEY is not set. Cannot decrypt.");- return ciphertext;+ // Return null instead of encrypted ciphertext to prevent sending encrypted tokens to providers+ return null;}const body = ciphertext.slice(PREFIX.length);const parts = body.split(":");if (parts.length !== 3) {console.error("[Encryption] Malformed encrypted value");- return ciphertext;+ // Return null instead of encrypted ciphertext to prevent sending malformed encrypted tokens to providers+ return null;}const [ivHex, encryptedHex, authTagHex] = parts;@@ -144,7 +146,8 @@ export function decrypt(ciphertext: string | null | undefined): string | null |} catch (err: unknown) {const message = err instanceof Error ? err.message : String(err);console.error("[Encryption] Decryption failed:", message);- return ciphertext;+ // Return null instead of encrypted ciphertext to prevent sending encrypted tokens to providers+ return null;}}diff --git a/tests/unit/db-encryption.test.ts b/tests/unit/db-encryption.test.tsindex 97b290f241..092743358f 100644--- a/tests/unit/db-encryption.test.ts+++ b/tests/unit/db-encryption.test.ts@@ -66,7 +66,7 @@ test("connection field helpers encrypt and decrypt all supported credential fielassert.deepEqual(decrypted, connection);});-test("decrypt returns the original ciphertext when the value is malformed or the key is wrong", async () => {+test("decrypt returns null when the value is malformed or the key is wrong", async () => {process.env.STORAGE_ENCRYPTION_KEY = "task-304-secret-c";const firstModule = await importFresh("src/lib/db/encryption.ts");const encrypted = firstModule.encrypt("top-secret");@@ -74,6 +74,8 @@ test("decrypt returns the original ciphertext when the value is malformed or theprocess.env.STORAGE_ENCRYPTION_KEY = "task-304-secret-d";const secondModule = await importFresh("src/lib/db/encryption.ts");- assert.equal(secondModule.decrypt(encrypted), encrypted);- assert.equal(secondModule.decrypt("enc:v1:not-valid"), "enc:v1:not-valid");+ // When decryption fails with wrong key, return null (not encrypted ciphertext)+ // This prevents sending encrypted tokens to APIs+ assert.equal(secondModule.decrypt(encrypted), null);+ assert.equal(secondModule.decrypt("enc:v1:not-valid"), null);});