Skip to content

Open-source AI coworkers that each get a computer of their own: a browser, files and tools, with every action decided before it happens and recorded after. Bring any AG-UI agent.

Require an explicit boolean on POST /api/components/:name/publication (#513)

Felix-Ayush00b9c0daf61b
diff --git a/server/src/components/routes.ts b/server/src/components/routes.ts
index a858bd2a..7de833cc 100644
--- a/server/src/components/routes.ts
+++ b/server/src/components/routes.ts
@@ -397,7 +397,18 @@ export function createComponentRoutes(
const body = (await context.req.json().catch(() => null)) as {
published?: unknown;
} | null;
- const published = body?.published !== false;
+ /*
+ * A real boolean, not truthiness. This used to read `body?.published !== false`, so an
+ * empty body, invalid JSON, `{}`, `"no"`, `0` and `null` all evaluated to true and
+ * *published* the component with a 200 and a `component.published` audit row. A toggle
+ * that publishes on malformed input fails open on the endpoint that decides what every
+ * Bot may draw, and the sibling toggles (`PUT /routines/:id/enabled`, channel pin/busy)
+ * all answer 400 on non-boolean. Only an explicit true or false moves anything.
+ */
+ if (typeof body?.published !== "boolean") {
+ return context.json({ error: "published must be true or false." }, 400);
+ }
+ const published = body.published;
try {
if (published) {
diff --git a/server/tests/component-publication.test.ts b/server/tests/component-publication.test.ts
new file mode 100644
index 00000000..6b842c22
--- /dev/null
+++ b/server/tests/component-publication.test.ts
@@ -0,0 +1,120 @@
+import { describe, expect, test } from "bun:test";
+import type { MiddlewareHandler } from "hono";
+import { Hono } from "hono";
+import type { AppVariables } from "../src/auth/guards";
+import { createComponentRoutes } from "../src/components/routes";
+import type { ComponentStore } from "../src/components/store";
+
+/**
+ * The switch that decides what every Bot may draw, held closed on doubt.
+ *
+ * The route used to read `body?.published !== false`, so an empty body, invalid JSON,
+ * `{}`, `"no"`, `0` and `null` all evaluated to true and *published* the component with a
+ * 200 and a `component.published` audit row. Only an explicit `false` unpublished. The
+ * sibling toggles (`PUT /routines/:id/enabled`, channel pin/busy) all answer 400 on a
+ * non-boolean; this one did the opposite of safe.
+ */
+
+const ADMIN = {
+ id: "u1",
+ email: "[email protected]",
+ role: "admin",
+} as const;
+
+function harness() {
+ const calls: { action: "publish" | "unpublish"; name: string }[] = [];
+ const store = {
+ publish: async (name: string) => {
+ calls.push({ action: "publish", name });
+ },
+ unpublish: async (name: string) => {
+ calls.push({ action: "unpublish", name });
+ },
+ } as unknown as ComponentStore;
+
+ const asAdmin: MiddlewareHandler<{ Variables: AppVariables }> = async (
+ context,
+ next,
+ ) => {
+ context.set("actor", { ...ADMIN });
+ await next();
+ };
+
+ const hono = new Hono().route(
+ "/components",
+ createComponentRoutes(store, asAdmin, undefined, async () => true),
+ );
+ return { calls, hono };
+}
+
+function post(body: string | null) {
+ return {
+ method: "POST",
+ headers: { "content-type": "application/json" },
+ ...(body === null ? {} : { body }),
+ };
+}
+
+describe("publishing a component", () => {
+ test("publishes on an explicit true", async () => {
+ const { calls, hono } = harness();
+ const response = await hono.request(
+ "http://t/components/showActivityReport/publication",
+ post(JSON.stringify({ published: true })),
+ );
+
+ expect(response.status).toBe(200);
+ await expect(response.json()).resolves.toEqual({ published: true });
+ expect(calls).toEqual([{ action: "publish", name: "showActivityReport" }]);
+ });
+
+ test("unpublishes on an explicit false", async () => {
+ const { calls, hono } = harness();
+ const response = await hono.request(
+ "http://t/components/showActivityReport/publication",
+ post(JSON.stringify({ published: false })),
+ );
+
+ expect(response.status).toBe(200);
+ await expect(response.json()).resolves.toEqual({ published: false });
+ expect(calls).toEqual([
+ { action: "unpublish", name: "showActivityReport" },
+ ]);
+ });
+
+ test.each([
+ ["an empty body", ""],
+ ["invalid JSON", "{not json"],
+ ["an empty object", "{}"],
+ ['the string "no"', '{"published":"no"}'],
+ ['the string "true"', '{"published":"true"}'],
+ ["zero", '{"published":0}'],
+ ["one", '{"published":1}'],
+ ["null", '{"published":null}'],
+ ["an object", '{"published":{}}'],
+ ["an array", '{"published":[]}'],
+ ])("refuses %s with 400 and changes nothing", async (_name, body) => {
+ const { calls, hono } = harness();
+ const response = await hono.request(
+ "http://t/components/showActivityReport/publication",
+ post(body),
+ );
+
+ expect(response.status).toBe(400);
+ await expect(response.json()).resolves.toEqual({
+ error: "published must be true or false.",
+ });
+ expect(calls).toEqual([]);
+ });
+
+ test("a missing body changes nothing", async () => {
+ const { calls, hono } = harness();
+ const response = await hono.request(
+ "http://t/components/showActivityReport/publication",
+ { method: "POST" },
+ );
+
+ expect(response.status).toBe(400);
+ expect(calls).toEqual([]);
+ });
+});