Skip to content

Open-source AI coworkers that each get a computer of their own: a browser, files and tools, with every action decided before it happens and recorded after. Bring any AG-UI agent.

Remove the temporary copy when saving a Bot's browser control fails (#653)

kevin874b1f887ee4
diff --git a/CHANGELOG.md b/CHANGELOG.md
index b795ef5a..544c7755 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -204,6 +204,14 @@ removes that deployment's database volume and nothing else.
Startup failures keep enough of the log to name the cause, with every secret value redacted, and
carry a support link a whitelabel build can point elsewhere.
+### A failed save of a Bot's browser control leaves no copy behind
+
+The computer keeps who holds a Bot's browser, and its handoff requests, in one file per Bot under
+the profiles volume, written to a temporary file first and renamed over it. When the write or the
+rename failed, the temporary file stayed, a readable copy of that state beside the real one, and
+every later failure added another. It is now removed whether or not the save succeeds, as the
+learning setup and the model sign-in file already do.
+
### A Bot's image pull finds the Docker credential helper beside Docker
A Docker install whose credential helper sits next to the `docker` binary rather than on the desktop
diff --git a/agent-computer/src/control-store.ts b/agent-computer/src/control-store.ts
index 2daf95ca..6dbf1d65 100644
--- a/agent-computer/src/control-store.ts
+++ b/agent-computer/src/control-store.ts
@@ -6,6 +6,7 @@ import {
openSync,
readFileSync,
renameSync,
+ rmSync,
writeFileSync,
} from "node:fs";
import { join } from "node:path";
@@ -131,14 +132,19 @@ export function createControlStore(
validate(state);
mkdirSync(directory, { recursive: true, mode: 0o700 });
const temporary = `${path}.${crypto.randomUUID()}.tmp`;
- const fd = openSync(temporary, "wx", 0o600);
try {
- writeFileSync(fd, JSON.stringify(state));
- fsyncSync(fd);
+ const fd = openSync(temporary, "wx", 0o600);
+ try {
+ writeFileSync(fd, JSON.stringify(state));
+ fsyncSync(fd);
+ } finally {
+ closeSync(fd);
+ }
+ renameSync(temporary, path);
} finally {
- closeSync(fd);
+ // A write or rename that fails must not leave the copy behind; after a rename it is gone.
+ rmSync(temporary, { force: true });
}
- renameSync(temporary, path);
},
};
}
diff --git a/agent-computer/tests/control-store.test.ts b/agent-computer/tests/control-store.test.ts
index d75699c1..045e4c8d 100644
--- a/agent-computer/tests/control-store.test.ts
+++ b/agent-computer/tests/control-store.test.ts
@@ -1,8 +1,9 @@
import { afterEach, expect, test } from "bun:test";
import {
+ mkdirSync,
mkdtempSync,
- readFileSync,
readdirSync,
+ readFileSync,
rmSync,
writeFileSync,
} from "node:fs";
@@ -10,6 +11,7 @@ import { tmpdir } from "node:os";
import { join } from "node:path";
import { createControl } from "../src/control";
import { createControlStore } from "../src/control-store";
+
const directories: string[] = [];
function fixture() {
const directory = mkdtempSync(join(tmpdir(), "control-store-"));
@@ -40,6 +42,23 @@ test("atomic persisted completion remains exact across reload and later request"
).not.toContain("private label");
expect(readdirSync(join(directory, ".control"))).toEqual(["bot-1.json"]);
});
+test("a save that cannot replace the state leaves no temporary copy behind", () => {
+ const { directory, store } = fixture();
+ // A directory where the state file goes makes the final rename fail.
+ mkdirSync(join(directory, ".control", "bot-1.json"), { recursive: true });
+ expect(() =>
+ store.save({
+ version: 1,
+ holder: "bot",
+ since: new Date().toISOString(),
+ resumeSnapshotRequired: false,
+ recoveryRequired: false,
+ requests: [],
+ aliases: {},
+ }),
+ ).toThrow();
+ expect(readdirSync(join(directory, ".control"))).toEqual(["bot-1.json"]);
+});
test("reload interrupts active requests and retains idempotent identity", async () => {
for (const take of [false, true]) {
const { store, control } = fixture();