Open-source AI coworkers that each get a computer of their own: a browser, files and tools, with every action decided before it happens and recorded after. Bring any AG-UI agent.
Ignore inherited provider and Bot registry entries (#697)
Charan Rathoref12836d0c6c6
diff --git a/CHANGELOG.md b/CHANGELOG.mdindex fdc2848c..b2db4f28 100644--- a/CHANGELOG.md+++ b/CHANGELOG.md@@ -48,6 +48,12 @@ refused in every mode, including `allow_all`, and the browser's WebRTC traffic nfilter instead of around it. A computer run without an API server can set`EGRESS_POLICY_REQUIRED=0` to keep the old behaviour.+### Provider and Bot lookups ignore inherited object properties++Unknown names such as `constructor` and `__proto__` no longer return an inherited+JavaScript object as a provider or Bot entry. Unknown providers return no spec, and+missing Bots raise the existing startup error. Configured providers and Bots are unchanged.+### A malformed `%` in a stream URL no longer returns a 500A request to `/api/computers/<id>/stream` whose id held a broken percent-escape, such as `%zz`, made the server throw and answer 500. It is now treated as not matching the stream route and goes through normal routing. Valid ids behave as before.diff --git a/shared/model-providers.test.ts b/shared/model-providers.test.tsindex 6f42fde3..ac71102f 100644--- a/shared/model-providers.test.ts+++ b/shared/model-providers.test.ts@@ -319,3 +319,18 @@ describe("what a Bot runs from the spec file", () => {);});});++describe("registry lookups ignore inherited object properties", () => {+ test("prototype names are not providers", () => {+ for (const name of ["constructor", "__proto__", "toString", "valueOf"]) {+ expect(providerSpec(name)).toBeUndefined();+ expect(keyVariableFor(name)).toBeUndefined();+ expect(baseUrlVariableFor(name)).toBeUndefined();+ }+ });+ test("prototype names are not Bot entries", () => {+ for (const name of ["constructor", "__proto__", "toString", "valueOf"]) {+ expect(() => botSettings(name, {})).toThrow(`bots has no ${name} entry`);+ }+ });+});diff --git a/shared/model-providers.ts b/shared/model-providers.tsindex ab1ca34d..ac7a7aa7 100644--- a/shared/model-providers.ts+++ b/shared/model-providers.ts@@ -166,7 +166,9 @@ export function providerSpec(provider: string | undefined,): ProviderSpec | undefined {const normalized = provider?.trim().toLowerCase() || "openai";- return MODEL_PROVIDERS[normalized as ModelProviderId];+ return Object.hasOwn(MODEL_PROVIDERS, normalized)+ ? MODEL_PROVIDERS[normalized as ModelProviderId]+ : undefined;}/** The environment variable this provider's key arrives in, or nothing for a provider unknown. */@@ -248,7 +250,9 @@ export function botSettings(env: Readonly<Record<string, string | undefined>> = process.env,pinnedProvider?: string,): BotSettings {- const entry = BOT_ENTRIES[botId];+ const entry = Object.hasOwn(BOT_ENTRIES, botId)+ ? BOT_ENTRIES[botId]+ : undefined;if (!entry) {fail(`bots has no ${botId} entry. Add one before this Bot reads the spec file.`,