Self-improving AI Employees for everyone
Python ai-agentsai-employeeai-employeesassistantautonomous-agentsco-employeescompanygrok-botinstinctloop-agentsmuseown-your-datapersonalself-hosted
"""Contract tests for ``services.parameter_resolver.ParameterResolver``.
Locks in the behaviour every template-using workflow depends on:
``{{nodeName.field}}`` resolution, nested-path navigation, structlog
compatibility, and type preservation for whole-value templates. The
structlog test is the important one — a stdlib ``logger.isEnabledFor``
call in this module silently crashed every dynamic-parameter execution
until commit 2026-04-24 fixed it to ``logger.is_enabled_for``.
"""
from __future__ import annotations
from unittest.mock import AsyncMock, MagicMock
import pytest
from services.parameter_resolver import ParameterResolver
pytestmark = pytest.mark.asyncio
def _make_resolver(outputs: dict) -> ParameterResolver:
"""Build a resolver wired to a canned {source_id: output_dict} map."""
db = MagicMock()
db.get_node_parameters = AsyncMock(return_value={})
async def get_output(session_id: str, source_id: str, _output_name: str):
return outputs.get(source_id)
return ParameterResolver(db, get_output)
async def test_resolves_whole_value_template_and_preserves_type():
resolver = _make_resolver({"trigger_1": {"count": 5}})
nodes = [{"id": "trigger_1", "type": "chatTrigger", "data": {"label": "Trigger"}}]
edges = []
resolved = await resolver.resolve({"count": "{{trigger.count}}"}, "target", nodes, edges, "s1")
# Whole-value template preserves native type (int, not str).
assert resolved["count"] == 5
async def test_resolves_interpolated_template_to_string():
resolver = _make_resolver({"trigger_1": {"name": "world"}})
nodes = [{"id": "trigger_1", "type": "chatTrigger", "data": {"label": "Trigger"}}]
resolved = await resolver.resolve({"greeting": "hello {{trigger.name}}!"}, "target", nodes, [], "s1")
assert resolved["greeting"] == "hello world!"
async def test_missing_key_replaces_with_empty_string():
resolver = _make_resolver({"trigger_1": {"text": "ok"}})
nodes = [{"id": "trigger_1", "type": "chatTrigger", "data": {"label": "Trigger"}}]
resolved = await resolver.resolve({"value": "{{trigger.bogus}}"}, "target", nodes, [], "s1")
assert resolved["value"] == ""
async def test_structlog_isEnabledFor_regression():
"""Regression guard: the resolver used to call ``logger.isEnabledFor``
which only exists on stdlib loggers; structlog's BoundLogger raises
AttributeError. That silently broke every dynamic-parameter execution
(node returned ``null`` / an unhelpful error envelope)."""
resolver = _make_resolver({"trigger_1": {"text": "hi"}})
nodes = [{"id": "trigger_1", "type": "chatTrigger", "data": {"label": "Trigger"}}]
# Forces entry into _resolve_templates with at least one {{}} param.
resolved = await resolver.resolve({"msg": "{{trigger.text}}"}, "target", nodes, [], "s1")
assert resolved["msg"] == "hi"
async def test_nested_navigation_with_array_index():
resolver = _make_resolver(
{
"upstream_1": {
"messages": [{"text": "first"}, {"text": "second"}],
}
}
)
nodes = [{"id": "upstream_1", "type": "httpRequest", "data": {"label": "Upstream"}}]
resolved = await resolver.resolve({"pick": "{{upstream.messages[1].text}}"}, "target", nodes, [], "s1")
assert resolved["pick"] == "second"
async def test_no_template_values_pass_through_unchanged():
resolver = _make_resolver({})
resolved = await resolver.resolve(
{"literal": "items.0.text", "flag": True, "n": 3},
"target",
[],
[],
"s1",
)
# No '{{' in value ⇒ resolver must not touch it.
assert resolved == {"literal": "items.0.text", "flag": True, "n": 3}
async def test_run_outputs_win_over_the_shared_session_store():
"""Every firing of a deployment shares one session store. Two concurrent
WhatsApp messages must each resolve ``{{trigger.sender}}`` to their own
sender, not to whichever firing wrote the store last."""
resolver = _make_resolver({"trigger_1": {"sender": "+1 555 other customer"}})
nodes = [{"id": "trigger_1", "type": "whatsappReceive", "data": {"label": "Trigger"}}]
resolved = await resolver.resolve(
{"to": "{{trigger.sender}}"},
"send_1",
nodes,
[],
"generation-scope",
run_outputs={"trigger_1": {"sender": "+1 555 this customer"}},
)
assert resolved["to"] == "+1 555 this customer"
async def test_nodes_outside_run_outputs_fall_back_to_the_store():
resolver = _make_resolver({"src_1": {"name": "Alice"}})
nodes = [
{"id": "src_1", "type": "httpRequest", "data": {"label": "Src"}},
{"id": "trigger_1", "type": "chatTrigger", "data": {"label": "Trigger"}},
]
resolved = await resolver.resolve(
{"line": "{{src.name}}: {{trigger.message}}"},
"target",
nodes,
[],
"s1",
run_outputs={"trigger_1": {"message": "hi"}},
)
assert resolved["line"] == "Alice: hi"
async def test_a_non_firing_trigger_does_not_leak_a_stale_store_value():
"""Temporal hands non-firing sibling triggers ``{not_triggered: True}``.
The store still holds the last message that trigger ever received, and
reading it would paste an old message into this run's prompt."""
resolver = _make_resolver({"tg_1": {"text": "a message from last week"}})
nodes = [{"id": "tg_1", "type": "telegramReceive", "data": {"label": "Telegram"}}]
resolved = await resolver.resolve(
{"prompt": "{{telegram.text}}"},
"agent_1",
nodes,
[],
"s1",
run_outputs={"tg_1": {"not_triggered": True}},
)
assert resolved["prompt"] == ""
async def test_run_outputs_get_the_android_template_view():
resolver = _make_resolver({})
nodes = [{"id": "bat_1", "type": "batteryMonitor", "data": {"label": "Battery"}}]
resolved = await resolver.resolve(
{"level": "{{battery.battery_level}}"},
"target",
nodes,
[],
"s1",
run_outputs={"bat_1": {"service_id": "battery", "data": {"battery_level": 80}}},
)
assert resolved["level"] == 80
async def test_template_view_flattens_android_data_and_passes_others_through():
from services.parameter_resolver import template_view
assert template_view("batteryMonitor", {"action": "status", "data": {"battery_level": 80}}) == {
"action": "status",
"data": {"battery_level": 80},
"battery_level": 80,
}
plain = {"data": {"x": 1}}
assert template_view("httpRequest", plain) is plain
async def test_node_executor_passes_this_runs_outputs_to_the_resolver(harness):
observed = {}
async def spy_resolve(params, node_id, nodes, edges, session_id, run_outputs=None):
observed["run_outputs"] = run_outputs
return params
ctx = harness.build_context(nodes=[], edges=[], extra={"outputs": {"trigger_1": {"sender": "me"}}})
await harness.executor.execute(
node_id="console_1",
node_type="console",
parameters={},
context=ctx,
resolve_params_fn=spy_resolve,
)
assert observed["run_outputs"] == {"trigger_1": {"sender": "me"}}
async def test_nested_dict_and_list_params_recurse():
resolver = _make_resolver({"src_1": {"name": "Alice"}})
nodes = [{"id": "src_1", "type": "httpRequest", "data": {"label": "Src"}}]
resolved = await resolver.resolve(
{
"config": {"greet": "hi {{src.name}}"},
"people": ["{{src.name}}", "static"],
},
"target",
nodes,
[],
"s1",
)
assert resolved["config"]["greet"] == "hi Alice"
assert resolved["people"] == ["Alice", "static"]