Self-improving AI Employees for everyone
Python ai-agentsai-employeeai-employeesassistantautonomous-agentsco-employeescompanygrok-botinstinctloop-agentsmuseown-your-datapersonalself-hosted
fix(tests): browser test fakes match the resolver and Profile
trohitg028e2c2a9648
diff --git a/server/tests/nodes/browser/test_browser_owners.py b/server/tests/nodes/browser/test_browser_owners.pyindex d6043897..9736da64 100644--- a/server/tests/nodes/browser/test_browser_owners.py+++ b/server/tests/nodes/browser/test_browser_owners.py@@ -36,6 +36,11 @@ async def native_reset_client(scope, *, status=None, workflow_type="AgentWorkfloreturn SimpleNamespace(get_workflow_handle=Mock(return_value=handle), data_converter=converter)+def authorized_browser_node():+ """resolve_browser_node's (graph, node) for tests that skip the saved-graph checks."""+ return AsyncMock(return_value=({}, {"id": "browser", "data": {"label": "Browser"}}))++@pytest.fixtureasync def database():engine = create_async_engine("sqlite+aiosqlite:///:memory:")@@ -329,7 +334,7 @@ async def test_viewer_routing_keeps_active_frozen_profile_after_parameter_edit(dawait session.commit()binding = {**await owners.bind_profile(db, "profile", "owner"), "workflow_id": "wf", "node_id": "browser"}await owners.claim_browser_task(db, binding, "owner", "task")- with patch("nodes.browser._handlers.resolve_browser_node", AsyncMock()):+ with patch("nodes.browser._handlers.resolve_browser_node", authorized_browser_node()):assert (await owners.routing_for_node(db, "wf", "browser", "owner"))["profile_id"] == "profile"await owners.release_browser_task(db, binding, "stale")assert (await owners.routing_for_node(db, "wf", "browser", "owner"))["profile_id"] == "profile"@@ -382,7 +387,7 @@ async def test_inprocess_delegated_claim_survives_stale_reset_and_cleans_up_withreturn {"response": "Complete"}runtime = BrowserRuntime()with patch("services.plugin.deps.get_database", return_value=db), \- patch("nodes.browser._handlers.resolve_browser_node", AsyncMock()), \+ patch("nodes.browser._handlers.resolve_browser_node", authorized_browser_node()), \patch("nodes.browser._runtime.get_browser_runtime", return_value=runtime), \patch.object(SpecializedAgentBase, "execute_op", reason):child = asyncio.create_task(BrowserAgentNode().execute_op(context, BrowserAgentParams()))@@ -454,7 +459,7 @@ async def test_ambiguous_active_browser_bindings_fail_closed(database):session.add(BrowserProfileOwner(profile_id="other", principal_id="owner", owner_id="alpha",task_id="other-task", workflow_id="wf", browser_node_id="browser"))await session.commit()- with patch("nodes.browser._handlers.resolve_browser_node", AsyncMock()), pytest.raises(NodeUserError, match="ambiguous"):+ with patch("nodes.browser._handlers.resolve_browser_node", authorized_browser_node()), pytest.raises(NodeUserError, match="ambiguous"):await owners.routing_for_node(db, "wf", "browser", "owner")diff --git a/server/tests/nodes/browser/test_system_browser.py b/server/tests/nodes/browser/test_system_browser.pyindex 3f199883..4c47d519 100644--- a/server/tests/nodes/browser/test_system_browser.py+++ b/server/tests/nodes/browser/test_system_browser.py@@ -264,7 +264,7 @@ async def test_open_reuses_running_profile_for_agent_and_viewer(monkeypatch):runtime._profiles["shared"] = existingstart = AsyncMock(side_effect=AssertionError("must reuse the profile's browser"))monkeypatch.setattr(runtime, "_start", start)- profile = SimpleNamespace(id="shared")+ profile = SimpleNamespace(id="shared", kind="shared")assert await runtime.open(profile) is existingassert await runtime.open(profile) is existingstart.assert_not_awaited()@@ -287,7 +287,7 @@ async def test_concurrent_opens_share_one_browser_start(monkeypatch):start = AsyncMock(side_effect=launch)monkeypatch.setattr(runtime, "_start", start)monkeypatch.setattr(runtime, "_ensure_reaper", Mock())- profile = SimpleNamespace(id="shared")+ profile = SimpleNamespace(id="shared", kind="shared")first = asyncio.create_task(runtime.open(profile))await asyncio.wait_for(entered.wait(), timeout=1)second = asyncio.create_task(runtime.open(profile))