Self-improving AI Employees for everyone
Python ai-agentsai-employeeai-employeesassistantautonomous-agentsco-employeescompanygrok-botinstinctloop-agentsmuseown-your-datapersonalself-hosted
style(client): raise the node icon token from 32px to 36px
trohitg1e7d4e47e909
diff --git a/CLAUDE.md b/CLAUDE.mdindex 4ed79d96..f7b41d3e 100644--- a/CLAUDE.md+++ b/CLAUDE.md@@ -456,7 +456,7 @@ locked by `server/tests/test_output_contract.py`.5. **No opacity arithmetic at call sites.** `bg-primary/10`, `border-node-agent/30`, `${color}25` template literals are forbidden. If a unique tint is needed, add a new variant to the theme (e.g., `--node-X-soft`, `--node-X-border`) and use it by name.6. **No theme-locked names in non-decorative code.** Avoid `bg-dracula-purple`, `text-dracula-cyan`, etc. unless the constant accent is intentional (action-button palette). Prefer the role token (`bg-node-agent`) so future themes redefine without code edits.7. **No `useAppTheme()` in new files.** It is grandfathered for the canvas node components and `EdgeConditionEditor` only because they interpolate per-definition `nodeColor`. Every other surface uses Tailwind + the tokens above.-8. **Icons → `lucide-react`.** Inline SVGs are reserved for non-iconographic graphics (charts, decorative shapes). Replace any `<svg>...</svg>` icon you encounter while editing. **Icon size is a token, never a class**: backend-declared node/provider icons render through `<NodeIcon size={...}>` with `theme.nodeSize.squareIcon` on canvas nodes (32px, the one node-icon size) or a `theme.iconSize.*` step elsewhere, and `NodeIcon` applies that token as width, height AND emoji font size so every icon kind draws at the same edge. Never pass `h-*` / `w-*` / `text-*` sizing to it — the theme type scale maps `text-3xl` to 44px, which is how emoji nodes once painted half again larger than SVG-backed nodes beside them.+8. **Icons → `lucide-react`.** Inline SVGs are reserved for non-iconographic graphics (charts, decorative shapes). Replace any `<svg>...</svg>` icon you encounter while editing. **Icon size is a token, never a class**: backend-declared node/provider icons render through `<NodeIcon size={...}>` with `theme.nodeSize.squareIcon` on canvas nodes (36px, the one node-icon size) or a `theme.iconSize.*` step elsewhere, and `NodeIcon` applies that token as width, height AND emoji font size so every icon kind draws at the same edge. Never pass `h-*` / `w-*` / `text-*` sizing to it — the theme type scale maps `text-3xl` to 44px, which is how emoji nodes once painted half again larger than SVG-backed nodes beside them.9. **Any `draggable` element that performs a function must ship a pointer-operable, non-drag control reaching the same end state through the same write path.** WCAG 2.2 SC 2.5.7 (Level AA); the sufficient technique is [G219](https://www.w3.org/WAI/WCAG22/Techniques/general/G219), the failure is [F108](https://www.w3.org/WAI/WCAG22/Techniques/failures/F108). Two traps worth stating: **keyboard support does not discharge it** — the Understanding doc is explicit that an equivalent counts only "*unless that equivalent keyboard operation also provides controls that can be clicked or tapped with a pointer*", because touchscreen users may have no keyboard. And the alternative must operate *the same function*, so extract the write into a shared helper rather than reimplementing it — see [`lib/workspaceFileAssign.ts`](./client/src/lib/workspaceFileAssign.ts), which both `ParameterRenderer.handleDrop` and `WorkspaceFilePickerDialog` call, with a test asserting the two paths produce deep-equal results.When in doubt, read [docs-internal/frontend_architecture.md](./docs-internal/frontend_architecture.md) before introducing new patterns.diff --git a/client/src/styles/theme.ts b/client/src/styles/theme.tsindex 8937c6ef..2ddf94d5 100644--- a/client/src/styles/theme.ts+++ b/client/src/styles/theme.ts@@ -258,7 +258,7 @@ export const theme = {// Node sizes (fixed per industry standard)nodeSize: {square: '64px', // SquareNode (design-system spec: 64px box)- squareIcon: '32px', // Icon inside square node (0.5 × box). The ONE+ squareIcon: '36px', // Icon inside square node (0.5625 × box). The ONE// node-icon size: every canvas node passes it to// <NodeIcon size=>, which applies it as width,// height and emoji font size together.diff --git a/docs-internal/design-system/HANDOFF.md b/docs-internal/design-system/HANDOFF.mdindex 28ffa86d..99d8344a 100644--- a/docs-internal/design-system/HANDOFF.md+++ b/docs-internal/design-system/HANDOFF.md@@ -270,7 +270,7 @@ The skins that use `uppercase` + wide tracking (Cyber at `.18em`, Greek at `.18e- **Pin your toolbar clusters.** The wordmark, workflow-name chip, mode toggle and action cluster all need `flex: none`; leave exactly one group (File/Edit/View) shrinkable. Without this the mode toggle collapses to a sliver in Cyber and Atomic.- **Test the widest theme, not the default.** Anything that fits in Light will overflow somewhere. Cyber and Greek are the stress cases.-Also: canvas node icons are **32px** everywhere, and the size is a token, not a class — `theme.nodeSize.squareIcon` in `client/src/styles/theme.ts` (0.5 x the 64px `nodeSize.square` box), passed to `NodeIcon` as `size=`; non-canvas surfaces use the `theme.iconSize.*` scale the same way. `NodeIcon` applies that one token as the box's width, height AND font size, so SVG, library and emoji icons all draw at the same edge. Never size an icon with Tailwind `h-*`/`text-*` classes: the theme type scale maps `text-3xl` to 44px, which is how emoji nodes once painted half again larger than every SVG-backed node beside them. Eight themes ship their own glyph set; Light, Dark, Plague and Surveillance fall through to lucide.+Also: canvas node icons are **36px** everywhere, and the size is a token, not a class — `theme.nodeSize.squareIcon` in `client/src/styles/theme.ts` (0.5625 x the 64px `nodeSize.square` box), passed to `NodeIcon` as `size=`; non-canvas surfaces use the `theme.iconSize.*` scale the same way. `NodeIcon` applies that one token as the box's width, height AND font size, so SVG, library and emoji icons all draw at the same edge. Never size an icon with Tailwind `h-*`/`text-*` classes: the theme type scale maps `text-3xl` to 44px, which is how emoji nodes once painted half again larger than every SVG-backed node beside them. Eight themes ship their own glyph set; Light, Dark, Plague and Surveillance fall through to lucide.---diff --git a/docs-internal/design-system/components/canvas/SquareNode.jsx b/docs-internal/design-system/components/canvas/SquareNode.jsxindex dec5d323..780769ab 100644--- a/docs-internal/design-system/components/canvas/SquareNode.jsx+++ b/docs-internal/design-system/components/canvas/SquareNode.jsx@@ -91,7 +91,7 @@ export function SquareNode({display: 'flex',alignItems: 'center',justifyContent: 'center',- fontSize: Math.round(size * 0.5), // = theme.nodeSize.squareIcon (32px at the 64px box)+ fontSize: Math.round(size * 0.5625), // = theme.nodeSize.squareIcon (36px at the 64px box)color: 'var(--fg-default)',}}>diff --git a/docs-internal/design-system/readme.md b/docs-internal/design-system/readme.mdindex 6e7bc4cd..c5e82b5c 100644--- a/docs-internal/design-system/readme.md+++ b/docs-internal/design-system/readme.md@@ -48,7 +48,7 @@ The app ships 12 visual themes (light, dark, Renaissance, Cyber, Edo, Steampunk## ICONOGRAPHY- **Lucide is the system icon set** (`lucide-react` in app; pinned CDN UMD in this kit). 1.5px–2px stroke, no fill, sized 12–20px, colored via `currentColor`. Common verbs: Play/Square (run/stop), Save, Settings, KeyRound (credentials), FolderOpen, FilePlus, Search, GripVertical (drag), PanelLeft/RightClose, ChevronDown, Zap (dev mode), Clock (normal mode).-- **Provider/brand logos** come from `@lobehub/icons` (OpenAI, Claude, Gemini, Groq, Ollama…) — colored brand marks, used at 12–32px on nodes and credential rows (always via the `theme.nodeSize.squareIcon` / `theme.iconSize.*` tokens, never ad-hoc pixel classes). In prototypes substitute colored dots or the service's official mark.+- **Provider/brand logos** come from `@lobehub/icons` (OpenAI, Claude, Gemini, Groq, Ollama…) — colored brand marks, used at 12–36px on nodes and credential rows (always via the `theme.nodeSize.squareIcon` / `theme.iconSize.*` tokens, never ad-hoc pixel classes). In prototypes substitute colored dots or the service's official mark.- **Node/service icons in production are backend-declared** (`asset:<key>` SVGs, `lucide:<Name>`, or plain emoji strings). Many shipped nodes use full-color emoji-style glyphs (🧠 memory, 🤖 agent robot, ⚙️ gear) — see `assets/product-canvas-screenshot.png`. The ⚙️ gear emoji is literally the node's settings button.- **Fallback icon is 📦.** Status communicated by 6–10px colored dot "pips", not icons.- **No icon font; no custom-drawn icon set.** Use Lucide via the `Icon` component (`components/icons/`), which renders from the lucide CDN bundle.diff --git a/docs-internal/theme_system.md b/docs-internal/theme_system.mdindex 99d365a8..4a2e4765 100644--- a/docs-internal/theme_system.md+++ b/docs-internal/theme_system.md@@ -233,7 +233,7 @@ the surrounding chrome. Every other surface uses Tailwind + tokens. New themes c- **Canvas-node class topology alignment** (W26) — TriggerNode, StartNode, ToolkitNode migrated from `.node` (rectangular spec-card) topology to `.sq-node` / `.sq-node-box` (square-icon node) topology so per-theme decorations (Steampunk brass rivets, Edo hanko seal, Surveillance REC LED, Renaissance gold emblem) reach them. Status pips, gear buttons, and React Flow handles on every node component now carry `.sq-node-pip` / `.sq-node-gear` / `.sq-node-handle.in/.out` (square nodes) or `.node-pip` / `.node-gear` / `.node-handle.in/.out` (rectangular nodes — AIAgentNode, TeamMonitorNode; the former `GenericNode` was retired with the spec-driven canvas). Pip background is data-driven via `data-status="idle | executing | waiting | success | error"` — base.css picks the colour from shadcn semantic tokens; per-theme files override. Inline JS-computed `backgroundColor` / `border` / `animation` on these elements stripped — CSS owns visuals. Cyber's `.node-trigger` rule extended to dual-target both rectangular and square topologies (`.sq-node.node-trigger .sq-node-box`). Orphan `.node-output` rule removed. EditableNodeLabel now emits both `sq-node-label` and `node-label` classNames so per-theme typography rules fire. StartNode reads `nodeColor` from `definition?.defaults?.color` instead of hardcoded `theme.dracula.cyan`.- **Audio fix** (W20) — `--sound-pack: chime` typo in `light.css` + `dark.css` was silently falling through to `'none'` (`chime` not in the engine's pack registry), making sound silent for the most-used themes. Renamed `light` → `parchment`, `dark` → `terminal`. Added `Sounds.unlock()` exported from [lib/sound.ts](../client/src/lib/sound.ts) plus a one-shot `pointerdown / keydown / touchstart` capture-phase listener in `useSoundSync()` ([hooks/useSound.ts](../client/src/hooks/useSound.ts)) so the AudioContext resumes on the user's first gesture (Chrome / Safari autoplay policy compliance).- **Canvas-node visual contract** (W21) — every node component (`AIAgentNode`, `SquareNode`, `TriggerNode`, `StartNode`, `ToolkitNode`, `TeamMonitorNode`; `GenericNode` at the time, since retired) stripped its inline `background` / `border` / `borderRadius` / `boxShadow` / `animation` props. Each now exposes the per-definition accent hex via `style={{ '--node-color': accentColor }}` on its outer wrapper. Visual styling lives in [base.css](../client/src/themes/base.css) defaults + per-theme overrides; `var(--node-color)` carries the plugin's `visuals.json` accent through CSS without fighting specificity. New `NodeStyle` helper type in [client/src/types/NodeTypes.ts](../client/src/types/NodeTypes.ts) (`React.CSSProperties & Record<\`--${string}\`, string | number>`) makes the inline custom-prop typecheck-clean.-- **Icon size is a token** — `NodeIcon` takes `size=` (`theme.nodeSize.squareIcon`, 32px, on every canvas node; a `theme.iconSize.*` step elsewhere) and applies it as width, height and emoji font size together. Sizing classes are never passed: `--text-3xl` is 44px in `base.css`, so a `text-3xl` emoji once dwarfed every SVG-backed node next to it.+- **Icon size is a token** — `NodeIcon` takes `size=` (`theme.nodeSize.squareIcon`, 36px, on every canvas node; a `theme.iconSize.*` step elsewhere) and applies it as width, height and emoji font size together. Sizing classes are never passed: `--text-3xl` is 44px in `base.css`, so a `text-3xl` emoji once dwarfed every SVG-backed node next to it.- **Per-theme icons** (W23) — [client/src/assets/icons/themedGlyphs.ts](../client/src/assets/icons/themedGlyphs.ts) ports all 290 SVG glyphs from `design_handoff_machinaos_themes/app/icons.js` (29 keys × 10 themes). [NodeIcon.tsx](../client/src/assets/icons/NodeIcon.tsx) consults `THEMED_GLYPHS[activeTheme][key]` first; falls through to `lucide-react` / `lobehub:` / `asset:` dispatch on miss. Renaissance gets heraldic shields, Cyber wireframe + glow, Plague woodcut hatching, etc. Light + dark themes have no entries — they fall through to existing dispatch.- **Canvas grid + cursors** (W24) — `--canvas-grid` and `--cursor-default` slots declared in [base.css](../client/src/themes/base.css) and bound to `.canvas-host`. Per-theme grids: Cyber 24px magenta+cyan grid, Surveillance CCTV crosshair + REC overlay, Renaissance fleur-de-lis cartography, Greek key meander, Steampunk brass bolt grid, Atomic mid-century starburst, Wasteland cracked-earth fissures, Rot flagstone, Plague broadsheet red-X. Custom cursors: Cyber crosshair reticle, Surveillance snooper reticle, Renaissance gold-leaf quill.- **Decorative HTML primitives** (W25) — [client/src/components/SvgFilterDefs.tsx](../client/src/components/SvgFilterDefs.tsx) mounts a hidden inline `<svg><defs>` at app root exposing `#ink-blot` (Renaissance edge warble), `#noise` (Wasteland turbulence), `#crt` (Cyber chromatic aberration) so per-theme `filter: url(#...)` rules resolve. The `DropCap.tsx` wrapper (`v-display drop-cap`) planned alongside it was never retained: no `DropCap` component, `drop-cap` class or `::first-letter` rule exists in the tree today. What survives is the bare `.v-display` display-typography co-class, which ten of the per-theme files style (`cyber.css` glitch-on-hover, `edo.css`, `greek.css`, ...).