Skip to content

Self-improving AI Employees for everyone

perf(client): React.memo every canvas node component + center AIAgentNode icon (Phase 3)

trohitg2bfc69c5c306
diff --git a/client/src/components/AIAgentNode.tsx b/client/src/components/AIAgentNode.tsx
index 8e7e7116..f6ea7cb0 100644
--- a/client/src/components/AIAgentNode.tsx
+++ b/client/src/components/AIAgentNode.tsx
@@ -1,4 +1,5 @@
-import React, { useState, useEffect, useMemo } from 'react';
+import React, { memo, useState, useEffect, useMemo } from 'react';
+import { nodePropsEqual } from './nodeMemoEquality';
import { Handle, Position, NodeProps } from 'reactflow';
import { NodeData } from '../types/NodeTypes';
import { useAppStore } from '../store/useAppStore';
@@ -342,4 +343,4 @@ const AIAgentNode: React.FC<NodeProps<NodeData>> = ({ id, type, data, isConnecta
);
};
-export default AIAgentNode;
+export default memo(AIAgentNode, nodePropsEqual);
diff --git a/client/src/components/GenericNode.tsx b/client/src/components/GenericNode.tsx
index 2e680c14..d8689be7 100644
--- a/client/src/components/GenericNode.tsx
+++ b/client/src/components/GenericNode.tsx
@@ -1,4 +1,5 @@
-import React, { useState, useEffect, useRef, useCallback } from 'react';
+import React, { memo, useState, useEffect, useRef, useCallback } from 'react';
+import { nodePropsEqual } from './nodeMemoEquality';
import { Handle, Position, NodeProps } from 'reactflow';
import { resolveNodeDescription } from '../lib/nodeSpec';
import { resolveIcon, resolveLibraryIcon } from '../assets/icons';
@@ -351,4 +352,4 @@ const GenericNode: React.FC<NodeProps<NodeData>> = ({ id, type, data, isConnecta
);
};
-export default GenericNode;
\ No newline at end of file
+export default memo(GenericNode, nodePropsEqual);
\ No newline at end of file
diff --git a/client/src/components/SquareNode.tsx b/client/src/components/SquareNode.tsx
index 390ee73b..0afef55d 100644
--- a/client/src/components/SquareNode.tsx
+++ b/client/src/components/SquareNode.tsx
@@ -1,4 +1,5 @@
-import React, { useState, useEffect, useRef, useCallback, useMemo } from 'react';
+import React, { memo, useState, useEffect, useRef, useCallback, useMemo } from 'react';
+import { nodePropsEqual } from './nodeMemoEquality';
import { Handle, Position, NodeProps } from 'reactflow';
import { NodeData } from '../types/NodeTypes';
import { useAppStore } from '../store/useAppStore';
@@ -578,4 +579,4 @@ const SquareNode: React.FC<NodeProps<NodeData>> = ({ id, type, data, isConnectab
);
};
-export default SquareNode;
\ No newline at end of file
+export default memo(SquareNode, nodePropsEqual);
\ No newline at end of file
diff --git a/client/src/components/StartNode.tsx b/client/src/components/StartNode.tsx
index 98548da9..31e55c4f 100644
--- a/client/src/components/StartNode.tsx
+++ b/client/src/components/StartNode.tsx
@@ -1,4 +1,5 @@
-import React, { useState, useEffect, useRef, useCallback } from 'react';
+import React, { memo, useState, useEffect, useRef, useCallback } from 'react';
+import { nodePropsEqual } from './nodeMemoEquality';
import { Handle, Position, NodeProps } from 'reactflow';
import { NodeData } from '../types/NodeTypes';
import { useAppStore } from '../store/useAppStore';
@@ -247,4 +248,4 @@ const StartNode: React.FC<NodeProps<NodeData>> = ({ id, type, data, isConnectabl
);
};
-export default StartNode;
+export default memo(StartNode, nodePropsEqual);
diff --git a/client/src/components/TeamMonitorNode.tsx b/client/src/components/TeamMonitorNode.tsx
index 6d6c523c..6e27fb43 100644
--- a/client/src/components/TeamMonitorNode.tsx
+++ b/client/src/components/TeamMonitorNode.tsx
@@ -1,4 +1,5 @@
-import React, { useState, useEffect, useCallback, useMemo } from 'react';
+import React, { memo, useState, useEffect, useCallback, useMemo } from 'react';
+import { nodePropsEqual } from './nodeMemoEquality';
import { Handle, Position, NodeProps, useEdges, useNodes } from 'reactflow';
import { NodeData } from '../types/NodeTypes';
import { useAppStore } from '../store/useAppStore';
@@ -267,4 +268,4 @@ const TeamMonitorNode: React.FC<NodeProps<NodeData>> = ({ id, type, data, isConn
);
};
-export default TeamMonitorNode;
+export default memo(TeamMonitorNode, nodePropsEqual);
diff --git a/client/src/components/ToolkitNode.tsx b/client/src/components/ToolkitNode.tsx
index 760ee151..c6830743 100644
--- a/client/src/components/ToolkitNode.tsx
+++ b/client/src/components/ToolkitNode.tsx
@@ -10,7 +10,8 @@
* - Input handle at BOTTOM (receives Android service nodes)
*/
-import React, { useState, useEffect, useRef, useCallback } from 'react';
+import React, { memo, useState, useEffect, useRef, useCallback } from 'react';
+import { nodePropsEqual } from './nodeMemoEquality';
import { Handle, Position, NodeProps } from 'reactflow';
import { NodeData } from '../types/NodeTypes';
import { useAppStore } from '../store/useAppStore';
@@ -349,4 +350,4 @@ const ToolkitNode: React.FC<NodeProps<NodeData>> = ({ id, type, data, isConnecta
);
};
-export default ToolkitNode;
+export default memo(ToolkitNode, nodePropsEqual);
diff --git a/client/src/components/TriggerNode.tsx b/client/src/components/TriggerNode.tsx
index 03ddc62c..0a1d5fa5 100644
--- a/client/src/components/TriggerNode.tsx
+++ b/client/src/components/TriggerNode.tsx
@@ -6,7 +6,8 @@
*
* Used for: cronScheduler, webhookTrigger, whatsappReceive, start
*/
-import React, { useState, useEffect, useRef, useCallback } from 'react';
+import React, { memo, useState, useEffect, useRef, useCallback } from 'react';
+import { nodePropsEqual } from './nodeMemoEquality';
import { Handle, Position, NodeProps } from 'reactflow';
import { NodeData } from '../types/NodeTypes';
import { useAppStore } from '../store/useAppStore';
@@ -430,4 +431,4 @@ const TriggerNode: React.FC<NodeProps<NodeData>> = ({ id, type, data, isConnecta
);
};
-export default TriggerNode;
+export default memo(TriggerNode, nodePropsEqual);
diff --git a/client/src/components/nodeMemoEquality.ts b/client/src/components/nodeMemoEquality.ts
new file mode 100644
index 00000000..5e47432d
--- /dev/null
+++ b/client/src/components/nodeMemoEquality.ts
@@ -0,0 +1,28 @@
+/**
+ * Shared `React.memo` equality function for React Flow custom node
+ * components. Compares only the props that affect the rendered output
+ * — `xPos` / `yPos` / `dragging` change on every drag tick but the
+ * visual positioning is handled by React Flow's transform layer, not
+ * by the inner component. Skipping those keeps the nodes cheap.
+ *
+ * Reference: https://reactflow.dev/learn/advanced-use/performance —
+ * "Components provided as props to <ReactFlow>, including custom
+ * node and edge components, should either be memoized using
+ * React.memo".
+ */
+
+import type { NodeProps } from 'reactflow';
+
+export function nodePropsEqual<T = any>(
+ prev: NodeProps<T>,
+ next: NodeProps<T>,
+): boolean {
+ return (
+ prev.id === next.id &&
+ prev.type === next.type &&
+ prev.selected === next.selected &&
+ prev.dragging === next.dragging &&
+ prev.data === next.data &&
+ prev.isConnectable === next.isConnectable
+ );
+}