Skip to content

Self-improving AI Employees for everyone

fix: Phase B plugin bugs (405/435 -> 422/435)

trohitg2e03eca7ec73
diff --git a/server/nodes/agent/claude_code_agent.py b/server/nodes/agent/claude_code_agent.py
index 8a7ede6b..294a1be6 100644
--- a/server/nodes/agent/claude_code_agent.py
+++ b/server/nodes/agent/claude_code_agent.py
@@ -9,7 +9,9 @@ from __future__ import annotations
import time
from datetime import datetime
-from typing import Any
+from typing import Any, Optional
+
+from pydantic import ConfigDict, Field
from core.logging import get_logger
from services.plugin import ActionNode, NodeContext, Operation, TaskQueue
@@ -21,6 +23,21 @@ from ._specialized import SpecializedAgentOutput, SpecializedAgentParams
logger = get_logger(__name__)
+class ClaudeCodeAgentParams(SpecializedAgentParams):
+ """Adds CLI-specific flags the handler body reads from payload."""
+
+ max_turns: int = Field(default=10, alias="maxTurns", ge=1)
+ max_budget_usd: float = Field(default=5.0, alias="maxBudgetUsd", ge=0.0)
+ system_prompt: Optional[str] = Field(default=None, alias="systemPrompt")
+ working_directory: Optional[str] = Field(default=None, alias="workingDirectory")
+ allowed_tools: str = Field(
+ default="Read,Edit,Bash,Glob,Grep,Write",
+ alias="allowedTools",
+ )
+
+ model_config = ConfigDict(populate_by_name=True, extra="ignore")
+
+
class ClaudeCodeAgentNode(ActionNode):
type = "claude_code_agent"
display_name = "Claude Code"
@@ -35,11 +52,11 @@ class ClaudeCodeAgentNode(ActionNode):
annotations = {"destructive": True, "readonly": False, "open_world": True}
task_queue = TaskQueue.AI_HEAVY
- Params = SpecializedAgentParams
+ Params = ClaudeCodeAgentParams
Output = SpecializedAgentOutput
@Operation("execute", cost={"service": "claude_code_agent", "action": "run", "count": 1})
- async def execute_op(self, ctx: NodeContext, params: SpecializedAgentParams) -> Any:
+ async def execute_op(self, ctx: NodeContext, params: ClaudeCodeAgentParams) -> Any:
from core.container import container
from services.claude_code_service import get_claude_code_service
from services.status_broadcaster import get_status_broadcaster
diff --git a/server/nodes/model/_base.py b/server/nodes/model/_base.py
index 3c6afc41..42074811 100644
--- a/server/nodes/model/_base.py
+++ b/server/nodes/model/_base.py
@@ -51,6 +51,16 @@ class ChatModelParams(BaseModel):
default=1.0, alias="topP", ge=0.0, le=1.0,
json_schema_extra={"numberStepSize": 0.1},
)
+ thinking_enabled: bool = Field(default=False, alias="thinkingEnabled")
+ thinking_budget: Optional[int] = Field(
+ default=None, alias="thinkingBudget", ge=1,
+ )
+ reasoning_effort: Optional[Literal["low", "medium", "high"]] = Field(
+ default=None, alias="reasoningEffort",
+ )
+ reasoning_format: Optional[Literal["parsed", "hidden"]] = Field(
+ default=None, alias="reasoningFormat",
+ )
model_config = ConfigDict(populate_by_name=True, extra="ignore")
diff --git a/server/nodes/skill/simple_memory.py b/server/nodes/skill/simple_memory.py
index 9af34919..319f0ed3 100644
--- a/server/nodes/skill/simple_memory.py
+++ b/server/nodes/skill/simple_memory.py
@@ -9,7 +9,7 @@ plus the live message log returned here.
from __future__ import annotations
-from typing import Any, Optional
+from typing import Any, Literal, Optional
from pydantic import BaseModel, ConfigDict, Field
@@ -27,6 +27,10 @@ class SimpleMemoryParams(BaseModel):
alias="memoryContent",
json_schema_extra={"rows": 12},
)
+ memory_type: Literal["buffer", "window"] = Field(
+ default="buffer", alias="memoryType",
+ )
+ clear_on_run: bool = Field(default=False, alias="clearOnRun")
long_term_enabled: bool = Field(default=False, alias="longTermEnabled")
retrieval_count: int = Field(
default=3, alias="retrievalCount", ge=1, le=20,
diff --git a/server/nodes/utility/console.py b/server/nodes/utility/console.py
index d65c1153..6fa55f3b 100644
--- a/server/nodes/utility/console.py
+++ b/server/nodes/utility/console.py
@@ -163,7 +163,7 @@ class ConsoleNode(ActionNode):
log_value = input_data
case "field":
if field_path:
- if "{{" not in field_path and field_path not in input_data:
+ if "{{" in field_path:
log_value = field_path
else:
log_value = _navigate_field_path(input_data, field_path)
@@ -189,12 +189,13 @@ class ConsoleNode(ActionNode):
"source_node_label": source_info.get("label") if source_info else None,
})
- # Pass through original input for downstream nodes.
+ # Pass through original input for downstream nodes; explicit keys
+ # take precedence over upstream keys of the same name.
return {
+ **input_data,
"label": label or f"Console ({ctx.node_id[:8]})",
"logged_at": datetime.now().isoformat(),
"format": format_type,
"data": log_value,
"formatted": formatted_output,
- **input_data,
}
diff --git a/server/nodes/utility/team_monitor.py b/server/nodes/utility/team_monitor.py
index a522111b..2815a4e2 100644
--- a/server/nodes/utility/team_monitor.py
+++ b/server/nodes/utility/team_monitor.py
@@ -12,6 +12,7 @@ from services.plugin import ActionNode, NodeContext, Operation, TaskQueue
class TeamMonitorParams(BaseModel):
team_id: str = Field(default="", alias="teamId")
auto_refresh: bool = Field(default=True, alias="autoRefresh")
+ max_history_items: int = Field(default=50, alias="maxHistoryItems", ge=1)
model_config = ConfigDict(populate_by_name=True, extra="allow")
@@ -66,7 +67,7 @@ class TeamMonitorNode(ActionNode):
}
status = await get_agent_team_service().get_team_status(team_id)
- max_history = ctx.raw.get("parameters", {}).get("maxHistoryItems", 50)
+ max_history = params.max_history_items
return {
"team_id": team_id,
"members": status.get("members", []),
diff --git a/server/services/plugin/trigger.py b/server/services/plugin/trigger.py
index 2b84403e..adf12243 100644
--- a/server/services/plugin/trigger.py
+++ b/server/services/plugin/trigger.py
@@ -91,7 +91,7 @@ class TriggerNode(BaseNode, abstract=True):
return self._wrap_error(start_time=start_time, error=f"Invalid parameters: {e}")
if self.mode == "event":
- waiter = event_waiter.register(
+ waiter = await event_waiter.register(
node_type=self.type,
node_id=node_id,
params=parameters,
diff --git a/server/tests/nodes/_mocks.py b/server/tests/nodes/_mocks.py
index e082aee3..9129bb08 100644
--- a/server/tests/nodes/_mocks.py
+++ b/server/tests/nodes/_mocks.py
@@ -192,7 +192,7 @@ def patched_event_waiter(canned_event: Optional[Dict[str, Any]] = None) -> Itera
waiter_mock = MagicMock(name="event_waiter")
waiter_mock.is_trigger_node = MagicMock(return_value=True)
- waiter_mock.register = MagicMock(return_value=MagicMock(id="waiter-test-id"))
+ waiter_mock.register = AsyncMock(return_value=MagicMock(id="waiter-test-id"))
waiter_mock.wait_for_event = AsyncMock(return_value=event_data)
waiter_mock.cancel = MagicMock(return_value=True)
waiter_mock.dispatch = MagicMock(return_value=1)
diff --git a/server/tests/nodes/test_telegram_social.py b/server/tests/nodes/test_telegram_social.py
index 7b214ce4..3096a3b9 100644
--- a/server/tests/nodes/test_telegram_social.py
+++ b/server/tests/nodes/test_telegram_social.py
@@ -256,7 +256,7 @@ def _make_waiter_stub(*, canned_event=None, is_trigger=True, wait_side_effect=No
display_name="Telegram Message",
)
)
- stub.register = MagicMock(return_value=waiter_obj)
+ stub.register = AsyncMock(return_value=waiter_obj)
# Kept for back-compat with tests still asserting wait_for_event calls.
if wait_side_effect is not None:
stub.wait_for_event = AsyncMock(side_effect=wait_side_effect)
diff --git a/server/tests/nodes/test_whatsapp.py b/server/tests/nodes/test_whatsapp.py
index 846cd5bc..b9b90b7e 100644
--- a/server/tests/nodes/test_whatsapp.py
+++ b/server/tests/nodes/test_whatsapp.py
@@ -357,7 +357,7 @@ def _make_waiter_stub(*, canned_event=None, is_trigger=True, wait_side_effect=No
display_name="WhatsApp Message",
)
)
- stub.register = MagicMock(return_value=waiter_obj)
+ stub.register = AsyncMock(return_value=waiter_obj)
# Kept for back-compat with tests still asserting wait_for_event calls.
if wait_side_effect is not None:
stub.wait_for_event = AsyncMock(side_effect=wait_side_effect)
diff --git a/server/tests/nodes/test_workflow_triggers.py b/server/tests/nodes/test_workflow_triggers.py
index f91ac23c..4a8cf9bf 100644
--- a/server/tests/nodes/test_workflow_triggers.py
+++ b/server/tests/nodes/test_workflow_triggers.py
@@ -69,7 +69,7 @@ def patched_trigger_waiter(
display_name="Test Trigger",
)
)
- mock.register = MagicMock(return_value=waiter_obj)
+ mock.register = AsyncMock(return_value=waiter_obj)
if raise_cancelled:
mock.wait_for_event = AsyncMock(side_effect=_asyncio.CancelledError())
else: